refactor(server): user ServerConfigBuilder to replace ServerBuilder's duplicate setter methods
#1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koushiro
changed the title
ServerConfigBuilder to replace Builder's duplicate setter methodsServerConfigBuilder to replace ServerBuilder's duplicate setter methods
… duplicate setter methods **CHANGES**: - add custom_tokio_runtime method for ServerConfigBuilder - add with_config constructor for ServerBuilder - add set_config method for ServerBuilder **BREAKING CHANGES**: - remove all config setter methods of ServerBuilder Signed-off-by: koushiro <[email protected]>
koushiro
force-pushed
the
improve-server-builder
branch
from
1d7e0a9
to
73d7518
Compare
|
@niklasad1 PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES:
custom_tokio_runtimemethod forServerConfigBuilderwith_configconstructor forServerBuilderset_configmethod forServerBuilderBREAKING CHANGES:
ServerBuilderClose #1486