Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use kube-prometheus main branch #48

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

metalmatze
Copy link
Member

We can just use the main branch.
The tags are really just for OpenShift versions to pin to.

We need these newer versions to enable native histograms in remote-write.

@metalmatze metalmatze requested review from maxbrunet and kakkoyun June 2, 2023 16:32
Copy link
Member

@maxbrunet maxbrunet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure we are not hitting breaking changes, I'd suggest to update the cluster from v1.24 to v1.26/v1.27 before (parca-dev/demo-infrastructure#8)

https://github.com/prometheus-operator/kube-prometheus#compatibility

@metalmatze
Copy link
Member Author

Seems like a plan! 👍

@metalmatze
Copy link
Member Author

We're on v1.27.6 now.
I'll rebase soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants