Feat/Delta support #183
Open
Feat/Delta support #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/helpers/misc.ts
Outdated
Comment on lines
188
to
195
| // eslint-disable-next-line @typescript-eslint/no-non-null-assertion | ||
| v = 27 + (bytes[32]! >> 7); | ||
| // eslint-disable-next-line @typescript-eslint/no-non-null-assertion | ||
| bytes[32]! &= 0x7f; // Clear the highest bit | ||
| } else { | ||
| // Extract v directly for 65-byte signature | ||
| // eslint-disable-next-line @typescript-eslint/no-non-null-assertion | ||
| v = bytes[64]!; |
There was a problem hiding this comment.
Is it expected that I don't have linter errors here without disabling?
There was a problem hiding this comment.
Strangely, I also don't have errors anymore 🤷
| import type { Address, ConstructFetchInput } from '../../types'; | ||
| import type { ParaswapDeltaAuction } from './helpers/types'; | ||
|
|
||
| type OrderFromAPI = Omit<ParaswapDeltaAuction, 'signature'>; |
There was a problem hiding this comment.
Just noticed, API now return a new orderHash field. Was added most likely with V2 release
src/methods/delta/postDeltaOrder.ts
Outdated
| import { DeltaAuctionOrder, ParaswapDeltaAuction } from './helpers/types'; | ||
|
|
||
| export type DeltaOrderToPost = { | ||
| partner?: string; // @TODO not sure if this is optional, need to check |
There was a problem hiding this comment.
It is indeed optional, just checked
'anon' is assigned if not specified during /post
src/sdk/simple.ts
Outdated
| @@ -117,16 +145,25 @@ export type NFTOrdersFetchMethods = GetNFTOrdersContractFunctions & | |||
| PostNFTOrderFunctions & | |||
| BuildNFTOrdersTxFunctions; | |||
|
|
|||
| export type DeltaFetchMehods = BuildDeltaOrderFunctions & | |||
There was a problem hiding this comment.
Suggested change
| export type DeltaFetchMehods = BuildDeltaOrderFunctions & | |
| export type DeltaFetchMethods = BuildDeltaOrderFunctions & |
src/index.ts
Outdated
| @@ -256,11 +313,27 @@ export type { | |||
| BuildNFTOrderInput, | |||
| BuildNFTOrderDataInput, | |||
| NFTOrdersUserParams, | |||
| //types for Delta methos | |||
There was a problem hiding this comment.
Suggested change
| //types for Delta methos | |
| //types for Delta methods |
tests/test.testX.ts
Outdated
There was a problem hiding this comment.
most likely this is left over from previous branches.
as discussed, let's cleanup this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for Delta v2
closes FRNT-847