Add null check for 2d context in CanvasView #1860
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dobesv
force-pushed
the
check-canvas-null
branch
from
0bc1f56
to
695ec61
Compare
|
I believe I found the cause of the issue that led me to this: https://bugs.webkit.org/show_bug.cgi?id=195325 Just a side-note for anyone running into this issue. This PR does not fix that issue, it just makes the error message clearer when it does happen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes we are getting errors logged and reported with the vague error message "null is not an object (evaluating r.save)".
I traced it to this line.
It seems there was already a similar check & error in CanvasProvider so I copied that error here.
Although this does not prevent the problem, it at least will give us a clearer error when the problem occurs.
As for why a 2D context cannot be created, we are still looking into it. Maybe the device (iPad) is running out of graphics memory?