Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly render gradients when strokeScaling = false #1822

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

adroitwhiz
Copy link
Contributor

@adroitwhiz adroitwhiz commented Jun 9, 2020

Description

In order to render gradients properly when strokeScaling is set to false on their corresponding items, their points must be transformed by strokeMatrix, which refers to the transformation matrix to be applied directly to the item's contents (path points, etc) as opposed to the canvas on which the item is drawn.

Related issues

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the JSHint rules (npm run jshint passes)

@adroitwhiz adroitwhiz force-pushed the fix-gradient-stroke-scaling-upstream branch 2 times, most recently from a190238 to 4bdd192 Compare June 9, 2020 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant