Reverse checkbox on smoke ring #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| const matchingPreset = presets.find((preset) => { | ||
| // Remove anything present in the preset that is not a param | ||
| const { seed, ...rest } = preset.params; | ||
| // We might need to remove properties present in the preset that are not changeable params in the future |
There was a problem hiding this comment.
I think I added this bit because it was causing it to crash when seed was provided by not expected.
There was a problem hiding this comment.
I removed it because I thought all presets now had seed in Leva, but I now see that it's not always the case (dots grid doesn't have it, for example). I'll put it back 👍
There was a problem hiding this comment.
Yeah I'd actually like to not have seed in Leva unless it's a non-animated shader. It just seems to confuse folks.
…ed in highlight hook
|
I think Ksenia updated the smoke ring in #34 so I'll close this, thanks for making the example. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reverse-checkbox.mov