-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.1-miners testing #30
Conversation
Fot GMiner, Z_EWBF, ... and zhash coins its better to use coin_extension_arguments, so you dont need to change miner_opts every time you want to switch coin. |
So you tested manifests with MINER_OPTS and COIN__EXTENSION_ARGUMENTS variables, you want test again without them or I just remove all? |
Either we save such arguments in 1bash for coin_opts as @papampi correctly suggested, or we implement such mapping in the miner wrapper. For example (thank you for recalling this otherwise I would have forgotten) this if block for XMR_Stak |
I removed already xext and opts from some spare manifests I tested long time ago, including those one he tested, and _EXTENSION_ARGUMENTS variables do not appear anymore in 1bash so whatever he tested via *_OPTS is still valid. That's why @delawr0190 noticed $OPTS had to be removed from EWBF hcd, I guess, otherwise he was getting duplicate arguments. |
Yes, I was seeing duplicated args. I’ll restart my testing with these new changes in place. 👍🏻 |
I say we merge these changes to 3.1-dev, but keep this PR open for more testing and editing. |
Last time I tried doing something similar github tricked me and closed the PR automatically... |
I’ll have these all done within 2 days, so we can leave it open, if possible, so that doesn’t happen. 🙏🏻 Also, who is going to address the mappings for gminer? I can, but I’m still not that familiar with nvOC so whatever I do is probably gonna need to be cleaned up. I can churn through the testing while somebody else adds the mappings. Please. |
You can open it again after making more changes to the branch, cant you? |
@delawr0190 |
It seems like it could be made easier to use if we did something like what @LuKePicci mentioned above for xmrstak. $ALGO and $COIN are already defined. We have everything that’s needed, I believe, to generate —algo and —pers for the user without requiring that they sprinkle more opts throughout 1bash. Maybe? I don’t run gminer so not entirely sure what all goes into it. Just trying to make it easier to use if possible. |
Every day new shitcoins and new algos pops out, then we should keep editing and editing,so users dont do anything ... |
I cant make the Z_EWBF to mine and it wont start. |
All looks good in its folder too:
|
Is the resulting command line correct? |
Not shows up the started miner command Z_EWBF:
Z-ENEMY:
|
ZEL Coin with Z_EWBF:
|
Removed |
Got it, now fixing. Does ethminer 0.16.0 gives the same error too? |
Dont think so, let me check again |
Ethminer is ok:
|
I will now fix that error in the eval, and add than we check again if this occurs. |
Got it, ZEL_OPTS variable not passing, but Z_EWBF_OPTS passes. |
I put together a testing framework to help with some of the changes (I was running them by hand, but there are so many changes daily that it got to the point where I had to re-run them and it takes so long). You guys are welcome to use it if you find it useful. I'm currently adding tests as I go for each miner. I should have them all added and able to be continuously tested within another day or so. Still building the tests out, but it's making it a lot easier. |
Sounds like this will be the most stable beta ever 😆 |
I finished my testing of 3.1. I pushed my changes to this branch that will fix the miners and their integration with Foreman. There are a couple of problems that remain, though, and I'm not entirely sure how you guys want to address them:
I'm using the default 3.1 install with no extra dependencies or anything, and the 3.1 miners branch. I'm not entirely sure if the illegal instruction errors are specific to my setup, but I'm using the base load and they seem to be happening. |
You should be able to solve most 'illegal instruction' errors by recompiling those miners. |
@LuKePicci |
I updated the error message a bit, suche that if a miner version does not exist it will tell that, but you should have seen some "COIN/LAGO not found" errors already into the main log. @papampi could you take care of redirecting 0miner errors and warnings to miner log as well? |
I think we used to have it in older versions, will add a redirect to screenlog again. |
Added pm output and warnings: |
Will run everything tonight |
@delawr0190 |
@delawr0190 |
Running tests now for all of these changes. |
It seems like xmrstak isn't working properly. The following is what I see in miners log:
|
All the rest are ok? |
Everything else passes. |
Then we can merge this. |
And thanks a lot for the helps and tests. |
So you're going to proceed with the release even though xmrstak doesn't work? |
xmr-stak has this problem since I remember. |
Well done, looks like this time 3.1 beta testing wouldn't least very long. |
Exactly. |
Using this to keep track of my testing of the 3.1 release. There will also be a corresponding PR onto the main nvOC repo for 1bash edits once I'm done.
Passed:
BMINER: 10.7.0
BMINER: 13.0.0
CLAYMORE: 11.9
CLAYMORE: 12.0
CryptoDredge: 0.14.0
CryptoDredge: 0.16.1
DSTM: 0.6.2
ETHMINER: 0.14
ETHMINER: 0.15
ETHMINER: 0.16
EWBF: 0.3.4b
GMINER: 1.15
LOLMINER: 0.43
PhoenixMiner: 3.5d
T_Rex: 0.8.8
T_Rex: 0.9.1
TPccminer: 2.3 (after recompile)
XMR_Stak: 2.5.2
Z_EWBF: 0.6
ZENEMYminer: 1.28
Failed:
ENERGIMINER: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.22' not found (required by ./energiminer)