Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.1-miners testing #30

Merged
merged 124 commits into from
Mar 3, 2019
Merged

3.1-miners testing #30

merged 124 commits into from
Mar 3, 2019

Conversation

delawr0190
Copy link
Collaborator

@delawr0190 delawr0190 commented Jan 23, 2019

Using this to keep track of my testing of the 3.1 release. There will also be a corresponding PR onto the main nvOC repo for 1bash edits once I'm done.

Passed:

BMINER: 10.7.0
BMINER: 13.0.0
CLAYMORE: 11.9
CLAYMORE: 12.0
CryptoDredge: 0.14.0
CryptoDredge: 0.16.1
DSTM: 0.6.2
ETHMINER: 0.14
ETHMINER: 0.15
ETHMINER: 0.16
EWBF: 0.3.4b
GMINER: 1.15
LOLMINER: 0.43
PhoenixMiner: 3.5d
T_Rex: 0.8.8
T_Rex: 0.9.1
TPccminer: 2.3 (after recompile)
XMR_Stak: 2.5.2
Z_EWBF: 0.6
ZENEMYminer: 1.28

Failed:

ENERGIMINER: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.22' not found (required by ./energiminer)

@papampi
Copy link
Owner

papampi commented Jan 23, 2019

Fot GMiner, Z_EWBF, ... and zhash coins its better to use coin_extension_arguments, so you dont need to change miner_opts every time you want to switch coin.
BTG example:
BTG_EXTENSION_ARGUMENTS="--algo 144_5 --pers BgoldPoW"

@papampi
Copy link
Owner

papampi commented Jan 23, 2019

So you tested manifests with MINER_OPTS and COIN__EXTENSION_ARGUMENTS variables, you want test again without them or I just remove all?

@LuKePicci
Copy link
Collaborator

I needed to define GMINER_OPTS in 1bash - I used "--algo 144_5 --pers ZelProof" - this probably isn't maintainable - seems like a mapping is needed somewhere.

Either we save such arguments in 1bash for coin_opts as @papampi correctly suggested, or we implement such mapping in the miner wrapper. For example (thank you for recalling this otherwise I would have forgotten) this if block for XMR_Stak
https://github.com/papampi/nvOC_by_fullzero_Community_Release/blob/52b858996e0bdb8ea51eb69bc6c78398cd2c65e5/0miner#L320
needs to be added into https://github.com/papampi/nvOC_miners/blob/3.1-miners/XMR_Stak/2.5.2/xmr-stak.nvoc.sh for almost the same reasons.

@LuKePicci
Copy link
Collaborator

LuKePicci commented Jan 23, 2019

So you tested manifests with MINER_OPTS and COIN__EXTENSION_ARGUMENTS variables, you want test again without them or I just remove all?

I removed already xext and opts from some spare manifests I tested long time ago, including those one he tested, and _EXTENSION_ARGUMENTS variables do not appear anymore in 1bash so whatever he tested via *_OPTS is still valid. That's why @delawr0190 noticed $OPTS had to be removed from EWBF hcd, I guess, otherwise he was getting duplicate arguments.

@delawr0190
Copy link
Collaborator Author

Yes, I was seeing duplicated args.

I’ll restart my testing with these new changes in place. 👍🏻

@papampi
Copy link
Owner

papampi commented Jan 23, 2019

I say we merge these changes to 3.1-dev, but keep this PR open for more testing and editing.

@LuKePicci
Copy link
Collaborator

LuKePicci commented Jan 23, 2019

Last time I tried doing something similar github tricked me and closed the PR automatically...

@delawr0190
Copy link
Collaborator Author

delawr0190 commented Jan 23, 2019

I’ll have these all done within 2 days, so we can leave it open, if possible, so that doesn’t happen. 🙏🏻

Also, who is going to address the mappings for gminer? I can, but I’m still not that familiar with nvOC so whatever I do is probably gonna need to be cleaned up. I can churn through the testing while somebody else adds the mappings. Please.

@papampi
Copy link
Owner

papampi commented Jan 23, 2019

You can open it again after making more changes to the branch, cant you?

@papampi
Copy link
Owner

papampi commented Jan 23, 2019

@delawr0190
GMiner works with no problem, you just need to add "--algo" and " --pers " to COIN_OPTS for GMINER, Z_EWBF for ZHASH coins

@delawr0190
Copy link
Collaborator Author

delawr0190 commented Jan 23, 2019

It seems like it could be made easier to use if we did something like what @LuKePicci mentioned above for xmrstak.

$ALGO and $COIN are already defined. We have everything that’s needed, I believe, to generate —algo and —pers for the user without requiring that they sprinkle more opts throughout 1bash.

Maybe? I don’t run gminer so not entirely sure what all goes into it. Just trying to make it easier to use if possible.

@papampi
Copy link
Owner

papampi commented Jan 23, 2019

Every day new shitcoins and new algos pops out, then we should keep editing and editing,so users dont do anything ...
I'm good if you guys like to make it more simple for users ;)

@papampi
Copy link
Owner

papampi commented Jan 23, 2019

I cant make the Z_EWBF to mine and it wont start.
Any ideas?

@papampi
Copy link
Owner

papampi commented Jan 23, 2019

All looks good in its folder too:

m1@m1-desktop:~$ ll NVOC/dev/miners/Z_EWBF/0.6/
total 1796
drwxrwxr-x 2 m1 m1    4096 Jan 23 01:44 ./
drwxrwxr-x 3 m1 m1    4096 Jan 23 01:44 ../
-rwxr-xr-x 1 m1 m1 1532744 Sep 29 19:34 miner*
-rwxr-xr-x 1 m1 m1     771 Jul 17  2018 miner.cfg*
-rw-rw-r-- 1 m1 m1    1057 Jan 23 01:44 .nvoc-miner.json
-rw-rw-r-- 1 m1 m1    1057 Jan 23 01:44 nvoc-miner.json
-rw-rw-r-- 1 m1 m1       5 Oct  2 13:17 version
-rw-rw-r-- 1 m1 m1  274520 Jan 20 19:37 z_ewbf_v0.6.tar.xz

m1@m1-desktop:~$ ll NVOC/dev/miners/Z_EWBF/latest/
total 1796
drwxrwxr-x 2 m1 m1    4096 Jan 23 01:44 ./
drwxrwxr-x 3 m1 m1    4096 Jan 23 01:44 ../
-rwxr-xr-x 1 m1 m1 1532744 Sep 29 19:34 miner*
-rwxr-xr-x 1 m1 m1     771 Jul 17  2018 miner.cfg*
-rw-rw-r-- 1 m1 m1    1057 Jan 23 01:44 .nvoc-miner.json
-rw-rw-r-- 1 m1 m1    1057 Jan 23 01:44 nvoc-miner.json
-rw-rw-r-- 1 m1 m1       5 Oct  2 13:17 version
-rw-rw-r-- 1 m1 m1  274520 Jan 20 19:37 z_ewbf_v0.6.tar.xz

@LuKePicci
Copy link
Collaborator

Is the resulting command line correct?

@papampi
Copy link
Owner

papampi commented Jan 23, 2019

Not shows up the started miner command

Z_EWBF:

DISABLED_GPUS not set
/home/m1/NVOC/dev/0miner: line 191: eval: --: invalid option
eval: usage: eval [arg ...]
screen -c /home/m1/NVOC/dev/screenrc-miner -dmSL miner /home/m1/NVOC/dev/miners/Z_EWBF/0.6/miner --fee 0 --server ${!xpool} --user ${!xaddr}${!xwallet}${!xwork} --pass $MINER_PWD --port ${!xport} $Z_EWBF_OPTS ${!xext}



Miner output: ./nvOC miner-log

Z-ENEMY:

LAUNCHING:  MINER (coin: RVN, algo: X16R)
    
DISABLED_GPUS not set
/home/m1/NVOC/dev/0miner: line 191: eval: --: invalid option
eval: usage: eval [arg ...]
screen -c /home/m1/NVOC/dev/screenrc-miner -dmSL miner /home/m1/NVOC/dev/miners/ZENEMYminer/latest/z-enemy $UCCALGO -o ${!xproto}://${!xpool}:${!xport} -u ${!xaddr}${!xwallet}${!xwork} -p $MINER_PWD -i ${!xintensity} $CCMINER_OPTS ${!xext}
    
    SCREEN -c /home/m1/NVOC/dev/screenrc-miner -dmSL miner /home/m1/NVOC/dev/miners/ZENEMYminer/latest/z-enemy -a x16r -o stratum+tcp://rvn.suprnova.cc:6667 -u papampi.nv100 -p x -i 0
    
Miner output: ./nvOC miner-log

@papampi
Copy link
Owner

papampi commented Jan 23, 2019

ZEL Coin with Z_EWBF:

LAUNCHING:  MINER (coin: ZEL, algo: ZHASH)
    
DISABLED_GPUS not set
/home/m1/NVOC/dev/0miner: line 191: eval: --: invalid option
eval: usage: eval [arg ...]
screen -c /home/m1/NVOC/dev/screenrc-miner -dmSL miner /home/m1/NVOC/dev/miners/Z_EWBF/0.6/miner --fee 0 --server ${!xpool} --user ${!xaddr}${!xwallet}${!xwork} --pass $MINER_PWD --port ${!xport} $Z_EWBF_OPTS ${!xext}
    
    
    
Miner output: ./nvOC miner-log
    



@papampi
Copy link
Owner

papampi commented Jan 23, 2019

Removed $Z_EWBF_OPTS and ${!xext} from manifest and still no go ...

@LuKePicci
Copy link
Collaborator

LuKePicci commented Jan 23, 2019

Got it, now fixing. Does ethminer 0.16.0 gives the same error too?

@papampi
Copy link
Owner

papampi commented Jan 23, 2019

Dont think so, let me check again

@papampi
Copy link
Owner

papampi commented Jan 23, 2019

Ethminer is ok:

LAUNCHING:  MINER (coin: ELLA, algo: ETHASH)
    
DISABLED_GPUS not set
/home/m1/NVOC/dev/0miner: line 191: eval: --: invalid option
eval: usage: eval [arg ...]
screen -c /home/m1/NVOC/dev/screenrc-miner -dmSL miner /home/m1/NVOC/dev/miners/ETHMINER/latest/ethminer -P ${!xproto}://${!xaddr}${!xwallet}${!xwork}:$MINER_PWD@${!xpool}:${!xport} -U
    
    SCREEN -c /home/m1/NVOC/dev/screenrc-miner -dmSL miner /home/m1/NVOC/dev/miners/ETHMINER/latest/ethminer -P stratum1+tcp://MY_ADDRESS.nv100:[email protected]:3030 -U
    
Miner output: ./nvOC miner-log
    
    
    SCREEN -c /home/m1/NVOC/dev/screenrc-miner -dmSL miner /home/m1/NVOC/dev/miners/ETHMINER/latest/ethminer -P stratum1+tcp://MY_ADDRESS.nv100:[email protected]:3030 -U
 m 18:35:10 ethminer ethminer 0.16.0
 m 18:35:10 ethminer Build: linux/release
cu 18:35:10 ethminer Using grid size: 8,192, block size: 128
 i 18:35:10 ethminer Configured pool ella.2miners.com:3030
 i 18:35:10 main     Selected pool ella.2miners.com:3030
 i 18:35:10 stratum  Stratum mode detected: ETHPROXY Compatible

@LuKePicci
Copy link
Collaborator

I will now fix that error in the eval, and add than we check again if this occurs.

@papampi
Copy link
Owner

papampi commented Jan 23, 2019

Got it, ZEL_OPTS variable not passing, but Z_EWBF_OPTS passes.
Some thing is missing for COIN_OPTS in 0miner

@delawr0190
Copy link
Collaborator Author

I put together a testing framework to help with some of the changes (I was running them by hand, but there are so many changes daily that it got to the point where I had to re-run them and it takes so long). You guys are welcome to use it if you find it useful.

I'm currently adding tests as I go for each miner. I should have them all added and able to be continuously tested within another day or so. Still building the tests out, but it's making it a lot easier.

https://github.com/delawr0190/foreman-nvoc-ci

@LuKePicci
Copy link
Collaborator

Sounds like this will be the most stable beta ever 😆

@delawr0190
Copy link
Collaborator Author

I finished my testing of 3.1. I pushed my changes to this branch that will fix the miners and their integration with Foreman.

There are a couple of problems that remain, though, and I'm not entirely sure how you guys want to address them:

  1. anxccminer is not a phi2 miner, but it's the default phi2 miner in 1bash.
  2. vertminer throws an 'illegal instruction' error when it's ran.
  3. tpccminer throws an 'illegal instruction' error when it's ran.
  4. silentminer depends on cuda 9.1, which isn't available.
  5. naccminer throws an 'illegal instruction' error when it's ran.
  6. ktccminer throws an 'illegal instruction' error when it's ran.
  7. ktccminer_cryptonight depends on cuda 9.1, which isn't available.
  8. energiminer: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.22' not found (required by ./energiminer).
  9. xmrstak is missing a symlink after install to recommended.
  10. once the symlink is fixed, xmrstak throws error while loading shared libraries: libmicrohttpd.so.12: cannot open shared object file: No such file or directory

I'm using the default 3.1 install with no extra dependencies or anything, and the 3.1 miners branch. I'm not entirely sure if the illegal instruction errors are specific to my setup, but I'm using the base load and they seem to be happening.

@LuKePicci
Copy link
Collaborator

LuKePicci commented Jan 27, 2019

You should be able to solve most 'illegal instruction' errors by recompiling those miners.
Same for those two which depends on cuda-9.1, however you should also be able to run them with a 9.2 runtime. Please confirm.
Will check the missing symlink. Also xmr-stak needs to be recompiled to depend on the libmicrohttpd version of your system, which is different between ubuntu 16 and 18.
I don't know anything about energiminer, will wait info from @papampi on this and let him choose another miner for phi2.
Thanks for the exhaustive reporting. Are you on the ubuntu18 or ubuntu16 image? 18 I guess...

@papampi
Copy link
Owner

papampi commented Feb 27, 2019

@LuKePicci
You are the best....
Looks like all are fixed, lets see how the rest of @delawr0190 tests goes

@LuKePicci
Copy link
Collaborator

It took me forever to figure out why the miner wasn't starting due to the missing sym link. It would be great if there was some output added to 0miner so it's obvious as to what's going on. I couldn't find any errors anywhere.

I updated the error message a bit, suche that if a miner version does not exist it will tell that, but you should have seen some "COIN/LAGO not found" errors already into the main log.

@papampi could you take care of redirecting 0miner errors and warnings to miner log as well?

@papampi
Copy link
Owner

papampi commented Feb 27, 2019

@papampi could you take care of redirecting 0miner errors and warnings to miner log as well?

I think we used to have it in older versions, will add a redirect to screenlog again.

@papampi
Copy link
Owner

papampi commented Feb 27, 2019

Added pm output and warnings:
papampi/nvOC_by_fullzero_Community_Release@8d94a1b

@delawr0190
Copy link
Collaborator Author

Will run everything tonight

@papampi
Copy link
Owner

papampi commented Mar 1, 2019

@delawr0190
Hopefully all is ok to start public beta testing.

@papampi
Copy link
Owner

papampi commented Mar 3, 2019

@delawr0190
Merge to 3.1 for beta testing?

@delawr0190
Copy link
Collaborator Author

Running tests now for all of these changes.

@delawr0190
Copy link
Collaborator Author

It seems like xmrstak isn't working properly. The following is what I see in miners log:

SCREEN -c /home/m1/NVOC/mining/screenrc-miner -dmSL miner /home/m1/NVOC/mining/miners/XMR_Stak/recommended/xmr-stak.nvoc.sh --config /home/m1/NVOC/mining/miners/XMR_Stak/recommended/config.txt --poolconf /home/m1/NVOC/mining/miners/XMR_Stak/recommended/pools.txt --nvidia /home/m1/NVOC/mining/miners/XMR_Stak/recommended/nvidia.txt --currency monero --noCPU --noAMD -o xmr.2miners.com:2222 -u 4B1hCWuXLRh5HRts6qzB88MnDgCC6JoPk9LNtkWSf9whL7it1CVXWXmjh5AheEEDzHC7PSDm5VKiL8pG4jJD9Y7vGJuxexC.nvOC-test -p x -i 0 --httpd 3333 SCREEN -c /home/m1/NVOC/mining/screenrc-miner -dmSL miner /home/m1/NVOC/mining/miners/XMR_Stak/recommended/xmr-stak.nvoc.sh --config /home/m1/NVOC/mining/miners/XMR_Stak/recommended/config.txt --poolconf /home/m1/NVOC/mining/miners/XMR_Stak/recommended/pools.txt --nvidia /home/m1/NVOC/mining/miners/XMR_Stak/recommended/nvidia.txt --currency monero --noCPU --noAMD -o xmr.2miners.com:2222 -u 4B1hCWuXLRh5HRts6qzB88MnDgCC6JoPk9LNtkWSf9whL7it1CVXWXmjh5AheEEDzHC7PSDm5VKiL8pG4jJD9Y7vGJuxexC.nvOC-test -p x -i 0 --httpd 3333
vm.nr_hugepages = 128
Please enter:

@papampi
Copy link
Owner

papampi commented Mar 3, 2019

All the rest are ok?
If I remember correct the first time you run xmr-stak you should click an enter on gnome-terminal after it asks to enter.

@delawr0190
Copy link
Collaborator Author

Everything else passes.

@papampi
Copy link
Owner

papampi commented Mar 3, 2019

Then we can merge this.
We can check to see if we can find a solution for xmr-stak later.

@papampi papampi merged commit 81266f3 into 3.1-miners Mar 3, 2019
@papampi
Copy link
Owner

papampi commented Mar 3, 2019

And thanks a lot for the helps and tests.

@delawr0190
Copy link
Collaborator Author

So you're going to proceed with the release even though xmrstak doesn't work?

@papampi
Copy link
Owner

papampi commented Mar 3, 2019

xmr-stak has this problem since I remember.
On first launch it asks for an enter, no idea why.

@LuKePicci
Copy link
Collaborator

Well done, looks like this time 3.1 beta testing wouldn't least very long.

@papampi
Copy link
Owner

papampi commented Mar 3, 2019

Exactly.

@delawr0190 delawr0190 deleted the 3.1-miners-prep branch March 4, 2019 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants