Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facebook box width is 48px #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JasonBarnabe
Copy link
Contributor

Even if you specify more in the URL params, Facebook's widget is only 48px wide.

@JasonBarnabe
Copy link
Contributor Author

Actually the width seems to change per-locale (to fit the local equivalent of "Like"):

de 80
en 47
es 73
fr 59
it 68
nl 86
pl 73
pt 55
ru 77

So this fixes English but breaks or makes worse other languages. Not sure if the library supports per-locale sizes?

@panzi
Copy link
Owner

panzi commented Feb 13, 2015

Exactly. It is even 82px for de_DE. The library does not support per locale size, so that's a problem. :/

@JasonBarnabe
Copy link
Contributor Author

With the iframe method I'm guessing we're stuck with a set width, but if we used Facebook's "HTML5" method, then the width would be dynamic.

Is there any particular reason we're using the iframe method?

@panzi
Copy link
Owner

panzi commented Feb 13, 2015

I'm not sure if it was facebook or another service that only worked once when not using the iframe. Meaning when you enable and then disable and then enable the button again the button didn't work (load). (Also an iframe of another domain cannot access the content of the embedding page.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants