Make menus: #399
Open
Make menus: #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rseabra
commented
Dec 2, 2022
rseabra
commented
- Not repeat the current page language
- point to the same page in the other languages rather than to the web site's root
1. Not repeat the current page language 2. point to the same page in the other languages rather than to the web site's root
|
Hi @panr why close without merge, anything wrong? |
|
Hi @rseabra, everything seems OK with your changes. I just want to start all over again with some things (ex. languages) and try something universal (I don't like the current "language menu" to be honest). If I don't come up with something new, I'll get back to your PR. |
|
Ok, thanks. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.