fixed SelectMultipleField none_of validator #538
Conversation
|
The CI is failing due to the issues fixed in #541. If you rebase your branch off of the current |
|
Also, can you please add some unit tests to this PR? |
| @@ -594,10 +594,20 @@ def __init__(self, values, message=None, values_formatter=None): | |||
| self.values_formatter = values_formatter | |||
|
|
|||
| def __call__(self, form, field): | |||
| if field.type == "SelectMultipleField": | |||
There was a problem hiding this comment.
This can't be the solution, as it excludes any other fields that have a list of data. And it just doesn't feel very good to check the name of a specific field like this.
Could maybe do if isinstance(field.data, list). That might have issues with FieldList, but that might not matter. Would also have issues if you want to check "none of these specific sets of choices", rather than "doesn't contain any of these choices".
| raise ValidationError( | ||
| message % dict(values=self.values_formatter(self.values)) | ||
| ) | ||
|
|
||
| if field.data in self.values: |
There was a problem hiding this comment.
If the field is SelectMultipleField, this behavior still triggers if the new if block doesn't raise. That would sort of address my point about validating lists vs items, but it doesn't seem like the right design because there's still no way to control which type of validation you intended.
|
Closing as inactive, and replaced by #807 |
none_of validator for SelectMultipleField is always true and will never raise a ValidationError.
none_of validator now supports both SelectField and SelectMultipleField.