Change map search to leaflet-control-geocoder with Nominatim #2221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hard codes my api key.
|
@mrjoes Please take a look. Thank you. |
|
Hey 👋 this feels like a good change to default behaviour - would you be willing to update this PR? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes code using Google Maps API and adds leaflet-control-geocoder. By default it uses the OSM Nominatim service which seems to work without an API key. Enable search control by default in example config.
Tested
Setup postgis and ran the demo app following examples/geo_alchemy/README.rst then created an object in the polygon table. With this change http://127.0.0.1:5000/admin/polygon/edit/?id=1&url=%2Fadmin%2Fpolygon%2F there is now a little search icon in the top right that can find place names.