Cleanup MRL / standardize more #1091
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericanderson
force-pushed
the
ea.cleanup-mrl
branch
from
d36d9b7 to
e06e4d3
Compare
ericanderson
changed the title
| const consumerCliPackages = [ | ||
| "@osdk/cli", | ||
| "@osdk/create-app", | ||
| "@osdk/foundry-sdk-generator", | ||
| ]; | ||
|
|
||
| const testWithHappyDomPackages = [ | ||
| const viteApp = [ |
There was a problem hiding this comment.
When we move widgets out or want to make more sample apps in other repo's, we'd have to update these first? When we move the MRL config out, is it somehow possible to make these inputs of some sort so these names come from the repos that the packages live in themselves?
There was a problem hiding this comment.
For both this var and others
There was a problem hiding this comment.
This file is part of a temporary state. The goal will be to refactor this whole file to be a "library" where individual repos would "configure" it with the packages in their own repo that fit the various archetypes.
nihalbhatnagar
previously approved these changes
Jan 14, 2025
policy-bot
bot
dismissed
nihalbhatnagar’s stale review
Invalidated by push of c6fe2de
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup MRL / standardize more
In commit order:
Wonky Codegen for
e2e.test.foundry-sdk-generatorThe existing code generated into the
srcwhich then required us to special case not including it in the tsc output. This was unnecessary and caused special casing in mrl that we could cleanup. We now expect codegen will go into either or both:./build/codegenand./src/generatedNoCheck.Codegen
Just regenerating
packages/e2e.sandbox.todoapp/src/generatedNoCheck2with extensionsProper extensions for e2e.sandbox.todoapp
Manually renaming remaining extensions in imports
Refactor
widget.vite-pluginto use standard pathsDrops a special snow flake tsconfig file. Produces output in a standardized location for turbo.
MRL applied boilerplate
I committed this prior to the MRL changes so that there would be no errors in lint-staged. This is just MRL applied changes for the next commit
Standardize vite apps
Break out 5 projects from
nonStandardPackagesintoviteAppandusesReact. Updates turbo.json with better defaults for the inputs and outputs of thebuildtask and adds comments explaining why things are there.Remove foundry-sdk-generator from snowflakes
Following the first commit and other prep work, this commit makes all consumer facing cli apps act the same. Notably this means must use exact version matches (this helps prevent surprises for us) just like foundry-sdk-generator used to do. We also had special casing for
consolain our tests but it didn't wire up to anything so was pointelessEmpty changeset
There isn't really anything to report here.