Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pick_phylopic uuid argument #96

Merged
merged 2 commits into from
Dec 19, 2023
Merged

pick_phylopic uuid argument #96

merged 2 commits into from
Dec 19, 2023

Conversation

LewisAJones
Copy link
Collaborator

No bells or whistles here! This updated functionality allows pick_phylopic to take uuids as an input. This will be most useful when users want to keep the same list of uuids to pick from (in case of changes to the API) and for working with resolve_phylopic. Note, documentation should be updated for the uuid argument to give resolve_phylopic as an example use case (or perhaps also include an example).

Closes #95.

@LewisAJones LewisAJones added this to the 1.3.0 milestone Dec 18, 2023
@LewisAJones LewisAJones self-assigned this Dec 18, 2023
@LewisAJones LewisAJones linked an issue Dec 18, 2023 that may be closed by this pull request
Copy link
Collaborator

@willgearty willgearty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, I just made one little change. Thanks @LewisAJones!

@willgearty willgearty merged commit ded8df0 into main Dec 19, 2023
5 of 8 checks passed
@willgearty willgearty deleted the uuid-pick-phylo branch December 19, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pick_phylopic should take uuids
2 participants