Fix color/fill defaults and behavior #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… update vignettes to use fill instead of color
LewisAJones
requested changes
Nov 20, 2023
There was a problem hiding this comment.
Hi @willgearty, thanks for getting this together! I've made a few comments and potentially caught some unexpected behaviour... let me know your thoughts!
L.
There was a problem hiding this comment.
Shouldn't this legend have a cat and a walrus?
| @@ -171,13 +171,12 @@ The `rotate_phylopic()` function can be used to rotate a silhouette an arbitrary | |||
| img_rot <- rotate_phylopic(img = img, angle = 45) | |||
| ``` | |||
|
|
|||
| Finally, the `recolor_phylopic()` function can be used to modify the color and/or transparency of a silhouette. The vast majority of PhyloPic silhouettes are black and fully opaque by default. However, it may be useful to change this when the you are trying to either match an existing visualization color palette or trying to convey extra information, such as categorical data, through color. | |||
| Finally, the `recolor_phylopic()` function can be used to modify the fill color, outline color, and/or transparency of a silhouette. The vast majority of PhyloPic silhouettes are solid black, are fully opaque, and have a transparent outline by default. However, it may be useful to change this when the you are trying to either match an existing visualization color palette or trying to convey extra information, such as categorical data, through color. | |||
There was a problem hiding this comment.
Suggested change
| Finally, the `recolor_phylopic()` function can be used to modify the fill color, outline color, and/or transparency of a silhouette. The vast majority of PhyloPic silhouettes are solid black, are fully opaque, and have a transparent outline by default. However, it may be useful to change this when the you are trying to either match an existing visualization color palette or trying to convey extra information, such as categorical data, through color. | |
| Finally, the `recolor_phylopic()` function can be used to modify the fill color, outline color, and/or transparency of a silhouette. The vast majority of PhyloPic silhouettes are solid black, are fully opaque, and have a transparent outline by default. However, it may be useful to change this when the you are trying to either match an existing visualization color palette or trying to convey extra information, such as categorical data, through color. |
Transparent outline or lack of outline?
| #' horizontal = hor, vertical = ver) | ||
| #' p + ggtitle("R Cat Herd!!") | ||
| add_phylopic <- function(img = NULL, name = NULL, uuid = NULL, filter = NULL, | ||
| x, y, ysize = Inf, | ||
| alpha = 1, color = "black", fill = NA, | ||
| alpha = 1, color = NA, fill = "black", |
There was a problem hiding this comment.
This doesn't seem to be consistent with add_phylopic_base?
| #' transparency (outline and fill) of the silhouettes, respectively. If | ||
| #' `color` is specified and `fill` is NA the outline and fill color will be | ||
| #' the same. If "original" is specified for the `color` aesthetic, the | ||
| #' The `color` (default: NA), `fill` (default: "black"), and `alpha` ( |
There was a problem hiding this comment.
I am not sure this is working as expected, e.g.
library(ggplot2)
df <- data.frame(x = c(2, 4), y = c(10, 20),
name = c("Felis silvestris catus", "Odobenus rosmarus"))
ggplot(df) +
geom_phylopic(aes(x = x, y = y, name = name), color = NA, size = 10) +
facet_wrap(~name) +
coord_cartesian(xlim = c(1,6), ylim = c(5, 30))
| #' The `color` (default: NA), `fill` (default: "black"), and `alpha` ( | ||
| #' default: 1) aesthetics can be used to change the outline color, fill color, | ||
| #' and transparency (outline and fill) of the silhouettes, respectively. If | ||
| #' `color` is specified and `fill` is NA `color` will be used as the fill |
There was a problem hiding this comment.
Again, I am not sure this is behaving as expected:
library(ggplot2)
df <- data.frame(x = c(2, 4), y = c(10, 20),
name = c("Felis silvestris catus", "Odobenus rosmarus"))
ggplot(df) +
geom_phylopic(aes(x = x, y = y, name = name), fill = NA, color = "blue", size = 10) +
facet_wrap(~name) +
coord_cartesian(xlim = c(1,6), ylim = c(5, 30))
LewisAJones
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the behavior of the
colorandfillarguments/aesthetics such that full backwards compatibility is now maintained (no more unnecessary outlines). I've also changed the defaults of these arguments and updated the examples and vignettes to better encourage folks to usefillinstead ofcolormoving forward.TLDR: no more chubby penguins
Fixes #87.