Compatibility with ShapeDiver #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BarChartGH and ColumnChartGH have been modified to make them compatible with the ShapeDiver Bitmap Parameter/Data Type. This also implies the charts produced can be used with Squid and Rooster
All Graphs/Charts made compatible with Bitmap Param
Bugfixes in chart/graph components and image component refactor for SD
Markdown to PDF and HTML component added, req libraries referenced.
Done to avoid merge conflicts with original repo
UX improvement + rendering bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding the Post-build Script:
I recommend simply using
Copy "$(TargetPath)" "$(TargetDir)Pterodactyl.gha"so that there are no conflicts for anyone willing to contribute or build the project themselves. You can use .ghlink files to reference the build files in your library folder. For example, my Pterodactyl.ghlink file is simply a renamed .txt file containing the textD:\Dropbox\Desktop\ShapeDiver\Plugin_Review\Pterodactyl\Repo\Pterodactyl\Pterodactyl\binand is located in the Libraries folder like any other .gha file