Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

カートリッジ最新化 #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

tomo-nishi
Copy link
Collaborator

No description provided.

@AyanaOzeki AyanaOzeki requested a review from vjcagay August 1, 2023 08:31
@AyanaOzeki
Copy link
Collaborator

AyanaOzeki commented Aug 1, 2023

@vjcagay
The cartridge developer has committed the latest version to the Github repository.
The specific change is the addition of a "metadata" field.
Please let me know if I need to issue a BDPA ticket to request a review.

@vjcagay
Copy link
Contributor

vjcagay commented Aug 7, 2023

@vjcagay The cartridge developer has committed the latest version to the Github repository. The specific change is the addition of a "metadata" field. Please let me know if I need to issue a BDPA ticket to request a review.

Hello @AyanaOzeki -san, please create a BDPA ticket so we can allocate some time for this. Thank you.

@codecov-commenter
Copy link

Codecov Report

Attention: 125 lines in your changes are missing coverage. Please review.

Comparison is base (df4c015) 78.15% compared to head (694bed8) 74.27%.

Files Patch % Lines
...sfra/cartridge/scripts/paidy/standard/authorize.js 76.33% 40 Missing ⚠️
...aidy/cartridge/scripts/paidy/standard/authorize.js 77.70% 33 Missing ⚠️
...rtridge/scripts/paidy/subscription/paidyPayment.js 75.78% 23 Missing ⚠️
...rtridge/scripts/paidy/subscription/paidyPayment.js 79.12% 19 Missing ⚠️
...es/int_paidy/cartridge/scripts/paidy/paidyUtils.js 37.50% 5 Missing ⚠️
...t_paidy_sfra/cartridge/scripts/paidy/paidyUtils.js 37.50% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
- Coverage   78.15%   74.27%   -3.88%     
==========================================
  Files          19       17       -2     
  Lines        1181     1003     -178     
  Branches      260      200      -60     
==========================================
- Hits          923      745     -178     
  Misses        258      258              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -31,7 +31,7 @@ This cartridge supports SFRA version 6.1.0 and SiteGenesis JS-Controllers

### Running integration tests
1. Download `app_storefront_base` cartridge
- URL : `https://github.com/paidy/SalesforceCommerceCloud-AppExchange`
- URL : `https://github.com/SalesforceCommerceCloud/storefront-reference-architecture`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomo-nishi ,
Hello, I think this URL should be https://github.com/paidy/SalesforceCommerceCloud-AppExchange, right. I tried to access https://github.com/SalesforceCommerceCloud/storefront-reference-architecture this link and it return 404 page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants