Remove unused storageProvider configuration from host.json #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📖 Terraform Plan ('infra/resources/dev') - successTerraform PlanTerraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# azurerm_monitor_diagnostic_setting.logs["cosmos-account"] will be updated in-place
~ resource "azurerm_monitor_diagnostic_setting" "logs" {
id = "/subscriptions/d7de83e0-0571-40ad-b63a-64c942385eae/resourceGroups/dx-d-itn-test-rg-01/providers/Microsoft.DocumentDB/databaseAccounts/dx-d-itn-playground-pg-cosno-01|cosmos-account-diagnostic-settings"
name = "cosmos-account-diagnostic-settings"
# (5 unchanged attributes hidden)
- metric {
- category = "Requests" -> null
- enabled = true -> null
- retention_policy {
- days = 0 -> null
- enabled = false -> null
}
}
- metric {
- category = "SLI" -> null
- enabled = true -> null
- retention_policy {
- days = 0 -> null
- enabled = false -> null
}
}
+ metric {
+ category = "AllMetrics"
+ enabled = true
}
# (3 unchanged blocks hidden)
}
# module.function_app.azurerm_linux_function_app.this will be updated in-place
~ resource "azurerm_linux_function_app" "this" {
~ app_settings = {
- "NODE_OPTIONS" = "--experimental-loader=@opentelemetry/instrumentation/hook.mjs" -> null
# (12 unchanged elements hidden)
}
id = "/subscriptions/d7de83e0-0571-40ad-b63a-64c942385eae/resourceGroups/dx-d-itn-test-rg-01/providers/Microsoft.Web/sites/dx-d-itn-playground-be-func-01"
name = "dx-d-itn-playground-be-func-01"
tags = {
"BusinessUnit" = "DevEx"
"CostCenter" = "TS000 - Tecnologia e Servizi"
"CreatedBy" = "Terraform"
"Environment" = "Dev"
"ManagementTeam" = "Developer Experience"
"Scope" = "Dynatrace PoC"
"Source" = "https://github.com/pagopa/dx-playground/tree/main/infra/repository"
}
# (31 unchanged attributes hidden)
# (3 unchanged blocks hidden)
}
# module.function_test_durable.azurerm_linux_function_app.this will be updated in-place
~ resource "azurerm_linux_function_app" "this" {
~ app_settings = {
+ "AzureFunctionsJobHost__extensions__durableTask__hubName" = "ProductionTaskHub"
+ "AzureFunctionsJobHost__extensions__durableTask__storageProvider__connectionStringName" = "DfStorageConnectionName"
# (6 unchanged elements hidden)
}
id = "/subscriptions/d7de83e0-0571-40ad-b63a-64c942385eae/resourceGroups/dx-d-itn-test-rg-01/providers/Microsoft.Web/sites/dx-d-itn-playground-df-func-01"
name = "dx-d-itn-playground-df-func-01"
tags = {
"BusinessUnit" = "DevEx"
"CostCenter" = "TS000 - Tecnologia e Servizi"
"CreatedBy" = "Terraform"
"Environment" = "Dev"
"ManagementTeam" = "Developer Experience"
"Scope" = "Dynatrace PoC"
"Source" = "https://github.com/pagopa/dx-playground/tree/main/infra/repository"
}
# (31 unchanged attributes hidden)
~ site_config {
- application_insights_connection_string = (sensitive value) -> null
~ application_insights_key = (sensitive value)
# (31 unchanged attributes hidden)
# (1 unchanged block hidden)
}
~ sticky_settings {
~ app_setting_names = [
# (2 unchanged elements hidden)
"AzureFunctionsWebHost__hostid",
- "APPINSIGHTS_INSTRUMENTATIONKEY",
- "APPLICATIONINSIGHTS_CONNECTION_STRING ",
- "APPINSIGHTS_PROFILERFEATURE_VERSION",
- "APPINSIGHTS_SNAPSHOTFEATURE_VERSION",
- "ApplicationInsightsAgent_EXTENSION_VERSION",
- "XDT_MicrosoftApplicationInsights_BaseExtensions",
- "DiagnosticServices_EXTENSION_VERSION",
- "InstrumentationEngine_EXTENSION_VERSION",
- "SnapshotDebugger_EXTENSION_VERSION",
- "XDT_MicrosoftApplicationInsights_Mode",
- "XDT_MicrosoftApplicationInsights_PreemptSdk",
- "APPLICATIONINSIGHTS_CONFIGURATION_CONTENT",
- "XDT_MicrosoftApplicationInsightsJava",
- "XDT_MicrosoftApplicationInsights_NodeJS",
]
# (1 unchanged attribute hidden)
}
# (1 unchanged block hidden)
}
# module.to_do_api.azurerm_api_management_api_policy.policy will be updated in-place
~ resource "azurerm_api_management_api_policy" "policy" {
id = "/subscriptions/d7de83e0-0571-40ad-b63a-64c942385eae/resourceGroups/dx-d-itn-test-rg-01/providers/Microsoft.ApiManagement/service/dx-d-itn-playground-pg-apim-01/apis/to-do-api"
~ xml_content = <<-EOT
- <policies>
- <inbound>
- <base />
- <set-backend-service backend-id="to-do-api-azure-function" />
- <!-- Append base-path, if defined, before invoking the backend -->
- <choose>
- <when condition="@(System.String.IsNullOrEmpty("api"))"></when>
- <otherwise>
- <rewrite-uri template="@(System.String.Concat("api/", context.Request.Url.Path))" />
- </otherwise>
- </choose>
- <set-header name="x-functions-key" exists-action="override">
- <value>{{to-do-api-function-key}}</value>
- </set-header>
- <cors>
- <allowed-origins>
- <origin>*</origin>
- </allowed-origins>
- <allowed-methods>
- <method>*</method>
- </allowed-methods>
- <allowed-headers>
- <header>*</header>
- </allowed-headers>
- <expose-headers>
- <header>*</header>
- </expose-headers>
- </cors>
- </inbound>
- <outbound>
- <base />
- </outbound>
- <backend>
- <base />
- </backend>
- <on-error>
- <base />
- </on-error>
+ <policies>
+ <inbound>
+ <base />
+ <set-backend-service backend-id="to-do-api-azure-function" />
+
+ <!-- Append base-path, if defined, before invoking the backend -->
+ <choose>
+ <when condition='@(System.String.IsNullOrEmpty("api"))'>
+ </when>
+ <otherwise>
+ <rewrite-uri template='@(System.String.Concat("api/", context.Request.Url.Path))' />
+ </otherwise>
+ </choose>
+
+ <set-header name="x-functions-key" exists-action="override">
+ <value>{{to-do-api-function-key}}</value>
+ </set-header>
+
+ <cors>
+ <allowed-origins>
+ <origin>*</origin>
+ </allowed-origins>
+ <allowed-methods>
+ <method>*</method>
+ </allowed-methods>
+ <allowed-headers>
+ <header>*</header>
+ </allowed-headers>
+ <expose-headers>
+ <header>*</header>
+ </expose-headers>
+ </cors>
+ </inbound>
+ <outbound>
+ <base />
+ </outbound>
+ <backend>
+ <base />
+ </backend>
+ <on-error>
+ <base />
+ </on-error>
</policies>
EOT
# (4 unchanged attributes hidden)
}
Plan: 0 to add, 4 to change, 0 to destroy.
Warning: Argument is deprecated
with azurerm_cosmosdb_sql_container.tasks,
on cosmos.tf line 37, in resource "azurerm_cosmosdb_sql_container" "tasks":
37: partition_key_path = "/id"
`partition_key_path` will be removed in favour of the property
`partition_key_paths` in version 4.0 of the AzureRM Provider.
(and one more similar warning elsewhere)
─────────────────────────────────────────────────────────────────────────────
Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminate the unused
storageProviderconfiguration from thehost.jsonfile to streamline the code.