Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fixing existing consumer test #39

Merged
merged 28 commits into from
Jun 25, 2024
Merged

chore: fixing existing consumer test #39

merged 28 commits into from
Jun 25, 2024

Conversation

Saup21
Copy link
Contributor

@Saup21 Saup21 commented Jun 5, 2024 •
edited by jira bot
Loading

mefellows
mefellows requested changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@mefellows mefellows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor comments.

client/client_pact_test.go Outdated Show resolved Hide resolved
client/client_pact_test.go Show resolved Hide resolved
client/client_pact_test.go Show resolved Hide resolved
Saup21 added 22 commits June 7, 2024 16:28
@Saup21
chore: fixing create environment case
7ada376
@Saup21
chore: fixed create and update secrets test
c49337d
@Saup21
chore: token regen test and webhooks test fixed
e2e8ca7
@Saup21
chore: get admin team test fixed
80d91eb
@Saup21
chore: fixed post webhooks response status
1b000d3
@Saup21
chore: fixed update teams test
63a4f20
@Saup21
chore: fixed update team assignment test
22a2471
@Saup21
chore: fixed create webhook test
f022dee
@Saup21
chore: added state to auth settings test and fixed the build
9e1b8e2
@Saup21
chore: fixed update user role test
d4a4f36
@Saup21
chore: updated pact-go and fixed location header in pact test
187529e
@Saup21
chore: added a script to fix the incorrect headers key matching rule …
eae6902 
…in pact file
@Saup21
fix: fixed a typo
973a614
@Saup21
test: testing if my script broke the build
146c6ae
@Saup21
chore: trying to update the makefile to run the transform script
5c74dc0
@Saup21
chore: force re-install latest ffi
e1b08c6
@Saup21
Revert "chore: force re-install latest ffi"
9175dc3 
This reverts commit e1b08c6.
@Saup21
chore: fixed invite user test
d53d7a0
@Saup21
chore: fixed update environment pact
e183246
@Saup21
chore: updated the pact-go version in makefile
a728e20
@Saup21
chore: debugging the pact file transform script
8c734a1
@Saup21
chore: updated the trasnform script
42559c4
@Saup21 Saup21 requested review from vwong and tuan-pham June 25, 2024 07:41
mefellows
mefellows approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@mefellows mefellows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor comments, but looks good otherwise. Feel free to merge when you're happy.

client/client_pact_test.go Show resolved Hide resolved
client/client_pact_test.go Outdated Show resolved Hide resolved
client/client_pact_test.go Outdated Show resolved Hide resolved
@mefellows mefellows merged commit b92a7a6 into master Jun 25, 2024
3 checks passed
@mefellows mefellows deleted the PACT-174-implement-provider-states-for-terraform-provider-pact-tests-in-the-pactflow-ruby-application branch June 25, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mefellows mefellows mefellows approved these changes

@rholshausen rholshausen Awaiting requested review from rholshausen

@pahnin pahnin Awaiting requested review from pahnin

@vwong vwong Awaiting requested review from vwong

@tuan-pham tuan-pham Awaiting requested review from tuan-pham

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Saup21 @mefellows