Add Ability to Source Username from External Secret #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @blakeromano Thanks for the PR, I'll aim to have a more in depth look at this because there are some tricky edge cases that we've had to tip toe around when it comes to the Postgres DB password logic. |
ChrisJBurns
requested changes
Jan 6, 2024
| {{- else }} | ||
| valueFrom: | ||
| secretKeyRef: | ||
| name: {{ include "broker.databaseUserSecretName" . }} |
There was a problem hiding this comment.
databaseUserSecretName or databaseUserSecretKey isn't defined anywhere in the tmpl file, you'll have to add it if you intend on using it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For databases that use a multi-user rotation strategy usernames and passwords are changed dynamically and we need the ability to source the username from an external secret the same as we do for DB Password.