-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add go-vendor-tools to sandcastle image #210
Conversation
go-vendor-tools is a new tool maintained by the Fedora Go SIG which helps with generating vendor archives and helping vendored Go packages follow the Licensing Guidelines. It is currently only available in Fedora, so we install it with pip.
Build failed. ✔️ pre-commit SUCCESS in 1m 36s |
recheck |
Build failed. ✔️ pre-commit SUCCESS in 1m 37s |
recheck |
Build failed. ✔️ pre-commit SUCCESS in 8m 21s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests are currently broken (fixing them is tracked in packit/deployment#543), but the image builds successfully, so let's merge this.
Thanks! When do you think the new sandcastle images will show up in prod? |
Next week on Monday (in the afternoon), but if you want you can already test it on stage: https://packit.dev/docs/configuration#packit_instances |
go-vendor-tools is a new tool maintained by the Fedora Go SIG which helps with generating vendor archives and helping vendored Go packages follow the Licensing Guidelines. It is currently only available in Fedora, so we install it with pip.
Relates: packit/packit#2382
This is a draft until https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-6545265745 goes through.
Add
go-vendor-tools
to the sandcastle container image.