Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go-vendor-tools to sandcastle image #210

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

gotmax23
Copy link
Contributor

go-vendor-tools is a new tool maintained by the Fedora Go SIG which helps with generating vendor archives and helping vendored Go packages follow the Licensing Guidelines. It is currently only available in Fedora, so we install it with pip.

Relates: packit/packit#2382


This is a draft until https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-6545265745 goes through.


Add go-vendor-tools to the sandcastle container image.

go-vendor-tools is a new tool maintained by the Fedora Go SIG which
helps with generating vendor archives and helping vendored Go packages
follow the Licensing Guidelines. It is currently only available in
Fedora, so we install it with pip.
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/03c9fb32b73c4215921d025cd9f4b02f

✔️ pre-commit SUCCESS in 1m 36s
sandcastle-tests NODE_FAILURE Node request 200-0007545242 failed in 0s

@nforro
Copy link
Member

nforro commented Sep 4, 2024

recheck

Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/a5989db616a74599a15f2b1021efdd21

✔️ pre-commit SUCCESS in 1m 37s
sandcastle-tests NODE_FAILURE Node request 200-0007563737 failed in 0s

@gotmax23 gotmax23 marked this pull request as ready for review September 4, 2024 13:09
@gotmax23
Copy link
Contributor Author

gotmax23 commented Sep 4, 2024

recheck

Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/1dbeb52881524559a96e62875e182202

✔️ pre-commit SUCCESS in 8m 21s
sandcastle-tests NODE_FAILURE Node request 200-0007563977 failed in 0s

Copy link
Member

@nforro nforro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are currently broken (fixing them is tracked in packit/deployment#543), but the image builds successfully, so let's merge this.

@nforro nforro merged commit 2d2348a into packit:main Sep 12, 2024
1 of 2 checks passed
@gotmax23
Copy link
Contributor Author

Thanks! When do you think the new sandcastle images will show up in prod?

@nforro
Copy link
Member

nforro commented Sep 12, 2024

When do you think the new sandcastle images will show up in prod?

Next week on Monday (in the afternoon), but if you want you can already test it on stage: https://packit.dev/docs/configuration#packit_instances

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants