Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable usage charts #702

Merged
merged 7 commits into from
Jul 20, 2023
Merged

fix: enable usage charts #702

merged 7 commits into from
Jul 20, 2023

Conversation

mfocko
Copy link
Member

@mfocko mfocko commented Jul 20, 2023

No description provided.

@mfocko
fix: enable usage charts
3e8104f 
Signed-off-by: Matej Focko <[email protected]>
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/554b41757a8c4882b8fe92b2ee7b37ce

✔️ pre-commit SUCCESS in 1m 02s

lbarcziova
lbarcziova approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/873c6533e3be4e1081b9ac5a9dd40ea0

✔️ pre-commit SUCCESS in 1m 02s

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/eef7db2202b24d7499e23c4990c6433f

✔️ pre-commit SUCCESS in 1m 09s

@mfocko
chore: remove and ignore generated graphs
2b26a28 
There is no need to commit the SVGs, since they are generate during the
build.

Signed-off-by: Matej Focko <[email protected]>
@mfocko
chore: adjust makefile for generating the usage
3557130 
Signed-off-by: Matej Focko <[email protected]>
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/60f9aa1e6f5d42039c18048e1d74ca82

✔️ pre-commit SUCCESS in 1m 02s

lbarcziova
lbarcziova approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

lachmanfrantisek
lachmanfrantisek approved these changes Jul 20, 2023
View reviewed changes
.github/workflows/deploy.yml
Comment on lines +24 to +27
- name: Generate newer usage graphs
run: |
pip3 install click requests pygal
python3 files/generate_usage.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I don't need to update manually..;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be a bit messy when running locally. It seems to run with each make run-dev, maybe we'll need to adjust it a bit.

@mfocko
Copy link
Member Author

mfocko commented Jul 20, 2023

GH Action has been changed, need to merge manually…

@mfocko mfocko merged commit ac18fa1 into packit:main Jul 20, 2023
1 check passed
@mfocko mfocko deleted the usage-charts-docusaurus branch July 20, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lachmanfrantisek lachmanfrantisek lachmanfrantisek approved these changes

@lbarcziova lbarcziova lbarcziova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfocko @lachmanfrantisek @lbarcziova