Skip to content

Commit

Permalink
Don't include OSH link in check title (#2623)
Browse files Browse the repository at this point in the history
Don't include OSH link in check title

In check title, markdown is not supported (and the URL is still present in the URL table).
RELEASE NOTES BEGIN
N/A
RELEASE NOTES END

Reviewed-by: Siteshwar Vashisht
Reviewed-by: Maja Massarini
  • Loading branch information
2 parents b3edc99 + a8e9008 commit 5b30e43
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
3 changes: 1 addition & 2 deletions packit_service/worker/handlers/open_scan_hub.py
Original file line number Diff line number Diff line change
Expand Up @@ -165,8 +165,7 @@ def run(self) -> TaskResults:
external_links = {"Added issues": self.get_issues_added_url()}
elif number_of_new_findings > 0:
description = (
f"{base_description} [{number_of_new_findings}"
f" new findings]({self.get_issues_added_url()}) identified."
f"{base_description} {number_of_new_findings} new findings identified."
)
external_links = {"Added issues": self.get_issues_added_url()}
else:
Expand Down
6 changes: 1 addition & 5 deletions tests/unit/test_open_scan_hub.py
Original file line number Diff line number Diff line change
Expand Up @@ -254,11 +254,7 @@ def test_handle_scan_task_finished(
if processing_results:
if scan_status == OpenScanHubTaskFinishedEvent.Status.success:
state = BaseCommitStatus.success
description = (
"Scan in OpenScanHub is finished. "
"[2 new findings](https://openscanhub."
"fedoraproject.org/task/15649/log/added.html) identified."
)
description = "Scan in OpenScanHub is finished. " "2 new findings identified."
flexmock(scan_mock).should_receive("set_status").with_args(
"succeeded",
).once()
Expand Down

0 comments on commit 5b30e43

Please sign in to comment.