Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase cpu limits for postgres #636

Merged
merged 6 commits into from
Jan 16, 2025

Conversation

majamassarini
Copy link
Member

If we don't set cpu limits they are being set by default (500m) but this value is too low for some of our pods.
Keep cpu limits.
Increase postgres cpu limit.

This reverts commit 453ef72.
If we don't set cpu limits then default limits appear (500m).
We need more than this in different pods, thus I keep the limits
and increase it even for postgres.
Today we were above 1 cpu usage. Let put here the max we can.
I also slightly increased valkey and pushgateway since sometimes we are close to the limit (looking at metrics).
The host key is not saved in the template anymore (for security reasons).
Skip checking differences in this key between template and local file.
Copy link
Contributor

When conditionalizing the templates for volume claim, do not create even
an empty object when it's not defined.

Better to avoid it altogether than nesting something by mistake.

Signed-off-by: Matej Focko <[email protected]>
URL contains colon for the protocol, quote it to prevent YAML parsing
issues.

Signed-off-by: Matej Focko <[email protected]>
Copy link
Contributor

Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could increase the CPU limit to 2 (the max allowed by cluster iiuc) also for other pods if needed, but from the metrics it looks like those are usually not problematic

@majamassarini
Copy link
Member Author

we could increase the CPU limit to 2 (the max allowed by cluster iiuc) also for other pods if needed, but from the metrics it looks like those are usually not problematic

yes, I discussed the same with @mfocko and we agreed that we should be ok with this limits for now 🤞🏻.

Copy link
Contributor

@majamassarini majamassarini force-pushed the increase-cpu-limits-for-postgres branch from e120365 to 972d20a Compare January 16, 2025 08:37
Copy link
Contributor

@majamassarini majamassarini added the mergeit When set, zuul wil gate and merge the PR. label Jan 16, 2025
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/941fb195c8234a299635498fed04275e

✔️ pre-commit SUCCESS in 1m 33s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 7812e9d into main Jan 16, 2025
4 checks passed
@lbarcziova lbarcziova deleted the increase-cpu-limits-for-postgres branch January 16, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants