fix(valkey): implement remarks from code review

- Remove tags for redis and redict, they would not be very helpful, since the specific implementation of KV-DB is taken from the variables anyways - Add missing Valkey to the deploymentconfigs - Asddd comment with ptions to the deployment templates Co-authored-by: Maja Massarini <[email protected]> Signed-off-by: Matej Focko <[email protected]>
packit · Oct 9, 2024 · 9bb28fb · 9bb28fb
1 parent 64cdcec
commit 9bb28fb
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 8 deletions.
diff --git a/playbooks/deploy.yml b/playbooks/deploy.yml
@@ -191,8 +191,6 @@
       when: with_kv_database
       tags:
         - kv_database
-        - redis
-        - redict
 
     - name: Deploy fluentd image stream and config
       ansible.builtin.include_tasks: tasks/k8s.yml

diff --git a/playbooks/roles/deploy/tasks/main.yml b/playbooks/roles/deploy/tasks/main.yml
@@ -149,8 +149,6 @@
   when: with_kv_database
   tags:
     - kv_database
-    - redis
-    - redict
 
 - name: Deploy fluentd image stream and config
   ansible.builtin.include_tasks: tasks/k8s.yml

diff --git a/playbooks/tasks/set-deployment-facts.yml b/playbooks/tasks/set-deployment-facts.yml
@@ -24,6 +24,7 @@
       nginx: "{{ with_pushgateway }}"
       redis: "{{ with_kv_database and kv_database == 'redis' }}"
       redict: "{{ with_kv_database and kv_database == 'redict' }}"
+      valkey: "{{ with_kv_database and kv_database == 'valkey' }}"
   tags:
     - always
 

diff --git a/vars/packit/dev_template.yml b/vars/packit/dev_template.yml
@@ -30,8 +30,10 @@ check_up_to_date: false
 # edit the queue name in secrets/*/fedora.toml
 with_fedmsg: false
 
-# kv_database: redict
-# with_kv_database: true
+# kv_database options: redis redict valkey
+# Current default on both deployments: valkey
+kv_database: valkey
+with_kv_database: true
 
 with_redis_commander: false
 

diff --git a/vars/packit/prod_template.yml b/vars/packit/prod_template.yml
@@ -32,7 +32,9 @@ api_key: ""
 # edit the queue name in secrets/*/fedora.toml
 # with_fedmsg: true
 
-# kv_database: valkey
+# kv_database options: redis redict valkey
+# Current default on both deployments: valkey
+kv_database: valkey
 # with_kv_database: true
 
 # with_redis_commander: false

diff --git a/vars/packit/stg_template.yml b/vars/packit/stg_template.yml
@@ -30,7 +30,9 @@ api_key: ""
 # edit the queue name in secrets/*/fedora.toml
 # with_fedmsg: true
 
-# kv_database: valkey
+# kv_database options: redis redict valkey
+# Current default on both deployments: valkey
+kv_database: valkey
 # with_kv_database: true
 
 # with_redis_commander: false