chore: add Vitest

[Venefilyn]

Adds Vitest

RELEASE NOTES BEGIN
Add Vitest for frontend testing
RELEASE NOTES END

[usercont-release-bot]

Preview: https://packit-dashboard-pr-465.surge.sh (deployed at Mon 25 Nov 2024, 13:49 UTC)

[softwarefactory-project-zuul]

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/267be59307e249cf94553aa29977b5e4

✔️ pre-commit SUCCESS in 2m 11s

[softwarefactory-project-zuul]

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/2759bb3fb76b49de9d8ff1e2490dca8e

✔️ pre-commit SUCCESS in 2m 17s

[softwarefactory-project-zuul]

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/810837bca61b4fd4b30e81d4fada5dcc

✔️ pre-commit SUCCESS in 2m 17s

[softwarefactory-project-zuul]

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/c07339690dbb423e8d2bfd291fa6d0db

✔️ pre-commit SUCCESS in 2m 13s

[softwarefactory-project-zuul]

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/7e9d083ebe7c4b5a8359f75981ff6f4b

✔️ pre-commit SUCCESS in 2m 14s

[softwarefactory-project-zuul]

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/dcbc28fe21f642fca7295f489f3d9955

✔️ pre-commit SUCCESS in 2m 21s

[softwarefactory-project-zuul]

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/d4bba7ec887e414ba4b89c09dad881b8

✔️ pre-commit SUCCESS in 2m 13s

[mfocko]

So the lockfile got removed in #473 just to be reintroduced here…

Saving the HTML generated by React sounds like something we do in ogr for git-forge responses for tests, but at the same time I wonder what's the point of testing here, when bumping a release might change the expected result. How are you even supposed to tell that something's broken when there's a constant flow of changes from the dependencies…

[mfocko]

Suggested change

	pull_request_target:
	pull_request:

_target is only needed when you want to utilize some kind of secrets

[Venefilyn]

@mfocko

So the lockfile got removed in #473 just to be reintroduced here…

There I removed a duplicate, no longer used, file as we had one in two spots. Bit confusing for sure but we should only have the one modified in this PR

Saving the HTML generated by React sounds like something we do in ogr for git-forge responses for tests, but at the same time I wonder what's the point of testing here, when bumping a release might change the expected result. How are you even supposed to tell that something's broken when there's a constant flow of changes from the dependencies…

In most scenarios it should not change, and is an indicator that things render correctly. We can setup scenarios for how things should look like given specific inputs, such as if the API server is down, one request succeeded but the other one failed etc.

So for the snapshots that render React it is small enough that any changes should only happen when code itself is changed, and if it is changed on each dependency update, that should be addressed for sure so it doesn't happen again (if nothing visual is changing that is). But PatternFly tends to keep visual changes to a minimum.

We can also do image/pixel tests if we want to instead, but that takes up a bit more storage

[softwarefactory-project-zuul]

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/77f48e8c97c3428b87666e56dd01d398

✔️ pre-commit SUCCESS in 2m 19s

[softwarefactory-project-zuul]

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/2e67284c7c6140ada7b5cc1e28f5e92e

✔️ pre-commit SUCCESS in 2m 18s

[mfocko]

There I removed a duplicate, no longer used, file as we had one in two spots. Bit confusing for sure but we should only have the one modified in this PR

OH! that's not a new file, that's 1k new lines in the existing one /o\