refactor: Move sidebar items around #336
Conversation
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 34s |
| @@ -101,16 +111,10 @@ const routes: RouteObject[] = [ | |||
| element: <Pipelines />, | |||
| path: "/pipelines", | |||
| handle: { | |||
| category: "Projects", | |||
| label: "Pipelines", | |||
| }, | |||
| }, | |||
There was a problem hiding this comment.
I would group projects, pipelines and jobs, but am not sure if Projects should be the name of the group.
But can't think of a better name. Maybe something with results, activity,... I don't know..;)
There was a problem hiding this comment.
I was thinking of adding this in the future so we can select the project we want and see the jobs and pipeline just for that project, then if you select none it shows all jobs and all pipelines. Could somehow get a page for just projects somehow though
But we could also leave it for now and just have the external links categorized
There was a problem hiding this comment.
OK, now I remember we've discussed this.
I quite like that approach (both having jobs and pipelines in a group now and the future state with the context selector). Maybe, I would just call this group differently.
A few ideas:
- Service
- Packit Service
- Records
- Results
- Dashboard(s)
- Workloads
- Processing
There was a problem hiding this comment.
I like both Dashboards and Services
There was a problem hiding this comment.
From these two, I slightly prefer Dashboards... Let's pick this and we can easily rename it if needed.
This will prepare us for more granular interaction with project selection in the future. For now until that is implemented we have this to go with.
Venefilyn
force-pushed
the
refactor/sidebar
branch
from
a90ad0c to
2a27ea9
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 19s |
This will prepare us for more granular interaction with project selection in the future. For now until that is implemented we have this to go with.
TODO:
Fixes
Related to
#306
Merge before/after
RELEASE NOTES BEGIN
Move sidebar routes around and categorize them
RELEASE NOTES END