Scan for positional items instead of trying to take the next available #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of picking the next unused one. `positional` should be used either after all the named items or as an item adjacent to a named item in some way, still after all the named items within the scope. In case of valid user input scanning for or picking up the front item gives the same results. When user specifies an invalid item - it will not be consumed during normal scanning so picking the front item fails. Error from positional item failing with "not present" will take the priority over "not expected" from invalid item resulting in a bad error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
positionalshould be used either after all the named items or as an item adjacent to a named item in some way, still after all the named items within the scope.In case of valid user input scanning for or picking up the front item gives the same results. When user specifies an invalid item - it will not be consumed during normal scanning so picking the front item fails.
Error from positional item failing with "not present" will take the priority over "not expected" from invalid item resulting in a bad errormessage.