Fix CI P4Runtime Spec #541
Conversation
Signed-off-by: Dscano <[email protected]>
docs/v1/Makefile
Outdated
| -rf build |
There was a problem hiding this comment.
Missing /bin/rm in this line?
Signed-off-by: Dscano <[email protected]>
Signed-off-by: Dscano <[email protected]>
docs/v1/Makefile
Outdated
| /bin/rm -rf build resources/figs/*.png |
There was a problem hiding this comment.
If we delete the resources/figs/*.png files, may as well also delete the *.svg files in that directory, too, yes?
There was a problem hiding this comment.
@Dscano @jafingerhut Is this resolved? I would like to merge this so incoming PRs can be synced.
Done |
|
@chrispsommers Looks reasonable to me now, Chris, in case you want to take a look and try merging it to see if it gets us closer. |
|
@chrispsommers I think as long as a PR is updating the .asciidoc version of the spec, and not the old .mdk Madoko spec, it should be good to merge it as soon as you approve of it. Any remaining changes for generating the HTML and PDF files and publishing can proceed later, independently of any spec changes. |
|
FYI, I just checked the "working draft" versions of the P4Runtime spec available on this page https://p4.org/specs/ today, and both the PDF and HTML versions are the new ones generated from AsciiDoc sources. Hurrah! |
As pointed out by Antonin here , the PR bringing back the build folder, where the
.pdfand.htmlspecs will be stored