Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable support for table property default_action for all v1model table types #5104

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Enable support for table property default_action for all v1model table types #5104

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e33b298
Enable support for table property default_action for all v1model tabl…
jafingerhut Jan 18, 2025
8dd7e8b
Merge remote-tracking branch 'upstream/main' into v1model-enable-defa…
jafingerhut Jan 18, 2025
0fdc054
Fix for compilation warning.
jafingerhut Jan 18, 2025
688b842
Fix more warnings
jafingerhut Jan 18, 2025
43c21c3
Restore call to handleTableImplementation
jafingerhut Jan 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions backends/bmv2/common/control.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ class ControlConverter : public Inspector {

auto propertyName = Standard::ActionProfileTraits<arch>::propertyName();
auto impl = table->properties->getProperty(propertyName);
bool simple = handleTableImplementation(impl, key, result, action_profiles, selector_check);
(void) handleTableImplementation(impl, key, result, action_profiles, selector_check);

unsigned size = 0;
auto sz = table->properties->getProperty("size");
Expand Down Expand Up @@ -378,14 +378,6 @@ class ControlConverter : public Inspector {
auto defact =
table->properties->getProperty(IR::TableProperties::defaultActionPropertyName);
if (defact != nullptr) {
if (!simple) {
::P4::warning(
ErrorType::WARN_UNSUPPORTED,
"Target does not support default_action for %1% (due to action profiles)",
table);
return result;
}

if (!defact->value->is<IR::ExpressionValue>()) {
::P4::error(ErrorType::ERR_EXPECTED, "%1%: expected an action", defact);
return result;
Expand Down
Loading