-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[P4Testgen] Add the Tofino testgen target. #5038
Conversation
37d6316
to
602ef1e
Compare
427b17d
to
3a126c4
Compare
3a126c4
to
f62132b
Compare
Signed-off-by: fruffy <[email protected]>
Signed-off-by: fruffy <[email protected]>
f62132b
to
4737cae
Compare
* and limitations under the License. | ||
* | ||
* | ||
* SPDX-License-Identifier: Apache-2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Should we use the abridged license?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can simplify this, @jafingerhut what is the format that you prefer here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SPDX-License-Identifier line looks perfect as is, as does the Copyright line. Those two are the minimum I would hope we have in every source file, since the top level LICENSE file should have the full text of the Apache2.0 license.
If we want any more than that, then the next smaller thing I am aware of is what the Apache 2.0 license recommends be in a source file, copied below from near the end of this page https://spdx.org/licenses/Apache-2.0.html which is what appears to be in the file right now, so I do not know which abbreviated license @pkotikal is referring to.
Copyright [yyyy] [name of copyright owner]
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jafingerhut, I was referring to https://github.com/ipdk-io/networking-recipe/blob/main/clients/client_cert_options.cc. But, this is fine. We are good @fruffy.
Can we add the tofino model binary to the docker image? |
Afaik we do not have a docker image for the studio yet. This could be very useful for testing P4C. Or we try to create a package from the open-p4studio that we can use. |
Signed-off-by: fruffy <[email protected]>
Signed-off-by: fruffy <[email protected]>
c1dc8b6
to
2492940
Compare
This adds the Tofino extension to P4Testgen. The only change necessary to the P4Testgen core was to skip extern resolution in method calls.
This extension can already generate tests but these test are not validated on the model because we do not have the infrastructure for it yet. Currently, we only check P4Testgen's Tofino extension by generating tests, then compiling the Tofino program.
Adding support for full P4Testgen runs on Tofino is future work.