avoid using already defined thread_local as variable name #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building p11-kit 0.25.5 with GCC15 on MinGW-w64 failed because `thread_local` is already defined for this platform. Resolved by changing the variable name from `thread_local` to `threadlocal`.
|
GCC 15 has not been released yet, could you confirm the compiler version? [EDIT] Reproduced in godbolt with GCC trunk: https://godbolt.org/z/P1j1vfeWM |
kalvdans
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
thread_local was added as a keyword in C23:
https://en.wikipedia.org/wiki/C23_(C_standard_revision)#Keywords
Instead of specifying -std=c17 I agree renaming a variable is best. (I have no merge rights)
|
Thinking more about it, we should instead (or in addition to the rename) make sure |
|
Yes, I was testing a snapshot version of GCC15 as it will default to See also: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=118283 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building p11-kit 0.25.5 with GCC15 on MinGW-w64 failed because
thread_localis already defined for this platform.Resolved by changing the variable name from
thread_localtothreadlocal.