Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI improvements #1036

Closed
wants to merge 9 commits into from
Closed

UI improvements #1036

wants to merge 9 commits into from

Conversation

lucianmocan
Copy link

This PR introduces the following changes and fixes:

  1. Modify "Show Footer" Appearance Setting

    • Renamed the setting to "Show Footer Everywhere". The idea is to always have the footer when clicking on the menu bar icon, but not necessarily on the .cursor setting. This makes it soo much better.
    • Ensures the footer is always visible when clicking the menu bar icon, but not necessarily in the .cursor setting. This enhances usability.
  2. Fix HistoryListView Height Issue

    • Resolved a bug where switching from a visible footer in the menu bar to an invisible footer in .cursor caused the panel to retain its previous size during the first toggle in .cursor.
  3. Add HistoryListView Custom Height Setting

    • Introduced a new appearance setting to allow users to customize the height of the HistoryListView.
  4. Relocate "Clear" Button

    • Moved the "Clear" button from the footer to the header, next to the search bar.
    • This layout also provides space for Maccy and allows .cursor mode to function without requiring the footer.
  5. UI Feedback for Empty Clipboard History

    • Added a user-friendly feedback message when the clipboard history is empty, improving the overall user experience.

Notes

  • I'm not a SwiftUI expert, so there might be areas that need refinement.
  • I’d greatly appreciate it if you could review my changes, make any necessary fixes, and merge the PR.
  • Also, I'm open to any feedback for future contributions.

Thank you for considering this contribution! 😊

@p0deje
Copy link
Owner

p0deje commented Jan 23, 2025

Thank you for the PR! Can you please share some screenshots of the new UI? I'm generally reluctant to make big changes there since Maccy attempts to preserve a menu-like experience that it had in version 1.

@lucianmocan
Copy link
Author

Screenshot 2025-01-24 at 00 55 57
Screenshot 2025-01-24 at 00 56 08
Screenshot 2025-01-24 at 00 56 19

@lucianmocan
Copy link
Author

with the app name : Screenshot 2025-01-24 at 00 57 46

@lucianmocan
Copy link
Author

Screenshot 2025-01-24 at 00 59 55

Copy link
Contributor

@weisJ weisJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some remarks from my side:

  • The setting for the height of the history list is not needed. You can already resize the window to your liking with the mouse.
  • As the header can be configured to only be visible during search, moving anything non-search related into the header is rather confusing e.g. with these changes (and the search bar hidden) you first have to search something to access the clear button. (Even worse if you have the header set to always be hidden)
  • The clear button takes up way more horizontal space than it needs to.
  • To warrant "backwards compatibility" the setting for the footer should at least be changed to something like "Show Footer: (Always, Status Item, Never)". This way people who use Maccy from the menu bar and still want the footer to be hidden can do so.

Having an option to hide the footer but keep it visible when opening through the status item is a good idea in my opinion. Though I am not sure the "clear" option is important enough to warrant it moving to a new location. If you want to clear the history can't you just -- as for opening the settings, if you don't want to use the keyboard shortcut -- open Maccy from the status item and use the clear option from there?

Maccy/Extensions/Defaults.Keys+Names.swift Show resolved Hide resolved
@lucianmocan
Copy link
Author

Thank you for your feedback.

  • Oh, I didn't know that was possible. I checked it, and yes, you're right...
  • I see the problem now. It seems better to keep the 'Clear' button in the footer.
  • More horizontal space is needed because when it changes to 'Clear All', it doesn't fit in the same space as before. However, since it's staying in the footer, this is no longer an issue.
  • I hadn't thought about that. Yes, that's a good idea.

I think I will close this pull request. I'll create another one later, taking all your feedback into account to see what the result will be.

@p0deje
Copy link
Owner

p0deje commented Jan 24, 2025

I don't want you to waste time working on this, so please consider my feedback before proceeding.

  1. Let's start with the problem first. What is the current issue you are trying to solve with this PR and why existing solutions are not sufficient?
  2. The UI should look the same regardless of whether you opened it via a menubar or a shortcut.
  3. The header should remain visually minimal, having a large button is not minimalistic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants