-
-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI improvements #1036
UI improvements #1036
Conversation
Thank you for the PR! Can you please share some screenshots of the new UI? I'm generally reluctant to make big changes there since Maccy attempts to preserve a menu-like experience that it had in version 1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some remarks from my side:
- The setting for the height of the history list is not needed. You can already resize the window to your liking with the mouse.
- As the header can be configured to only be visible during search, moving anything non-search related into the header is rather confusing e.g. with these changes (and the search bar hidden) you first have to search something to access the clear button. (Even worse if you have the header set to always be hidden)
- The clear button takes up way more horizontal space than it needs to.
- To warrant "backwards compatibility" the setting for the footer should at least be changed to something like "Show Footer: (Always, Status Item, Never)". This way people who use Maccy from the menu bar and still want the footer to be hidden can do so.
Having an option to hide the footer but keep it visible when opening through the status item is a good idea in my opinion. Though I am not sure the "clear" option is important enough to warrant it moving to a new location. If you want to clear the history can't you just -- as for opening the settings, if you don't want to use the keyboard shortcut -- open Maccy from the status item and use the clear option from there?
Thank you for your feedback.
I think I will close this pull request. I'll create another one later, taking all your feedback into account to see what the result will be. |
I don't want you to waste time working on this, so please consider my feedback before proceeding.
|
This PR introduces the following changes and fixes:
Modify "Show Footer" Appearance Setting
.cursor
setting. This enhances usability.Fix HistoryListView Height Issue
.cursor
caused the panel to retain its previous size during the first toggle in.cursor
.Add HistoryListView Custom Height Setting
Relocate "Clear" Button
.cursor
mode to function without requiring the footer.UI Feedback for Empty Clipboard History
Notes
Thank you for considering this contribution! 😊