Feature/cycle popup v2 #1013
Closed
Feature/cycle popup v2 #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added the option to record a shortcut for "cycling over the selection
on repeated press". Quick and easy way to iterate over common used
paste options.
- CycleSelection is where most of the logic is stored. We use CGEvent instead
of NSEvent.addGlobalXMonitorForEvents because the latter doesn't allow
taking over the event, which can lead to weird behavior. Note: right now
this leads to a mix of NSEvent and CGEvent in the code which is not ideal.
- Added tests for new feature
- Split class MaccyUITests into BaseTest to re-use code
alexisgaziello
force-pushed
the
feature/cycle-popup-v2
branch
from
343c58b to
6e85319
Compare
alexisgaziello
force-pushed
the
feature/cycle-popup-v2
branch
2 times, most recently
from
5e06f05 to
b776c1e
Compare
alexisgaziello
force-pushed
the
feature/cycle-popup-v2
branch
from
b776c1e to
c238bf4
Compare
alexisgaziello
force-pushed
the
feature/cycle-popup-v2
branch
from
c238bf4 to
9d97115
Compare
|
Closed in favor of: #1016 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Option B, code is not ready to get merged, but behavior is ready to get tested