Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#11 #12 - Bootstrap enhancements #13

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bobeal
Copy link
Member

@bobeal bobeal commented Aug 11, 2016

No description provided.

@bobeal bobeal changed the title 11 12 bootstrap enhancements #11 #12 - Bootstrap enhancements Aug 11, 2016
@bobeal
Copy link
Member Author

bobeal commented Aug 11, 2016

Build seems to fail because of the version update of error prone in 506ba4f ... as I can see in tbroyer/gradle-errorprone-plugin#18 :-)

Downgrading it for the build to pass.

build.gradle Outdated
@@ -38,7 +38,7 @@ subprojects {

apply plugin: 'net.ltgt.errorprone'
configurations.errorprone {
resolutionStrategy.force 'com.google.errorprone:error_prone_core:2.0.11'
resolutionStrategy.force 'com.google.errorprone:error_prone_core:2.0.5'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe I already have a fix for that, I must have forgotten to push it to the public repo on GitHub.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, that was it: forgot to push 7223c85

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you prefer to handle it wrt this PR ? Rebase the branch on master or merge master into it ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll rebase anyway; but please rebase the branch (skipping this commit) to fix conflicts (in INSTALL.md, in other commits). Also, as you're at it, squash the last two commits into the appropriate previous commits to keep the history as clean as possible.

@tbroyer
Copy link
Contributor

tbroyer commented Aug 22, 2016

Should we also bootstrap CKAN btw? (as I understand it, DC Exporter is rather useless without CKAN, right?)

@bobeal bobeal force-pushed the 11-12-bootstrap-enhancements branch from c4a9e4b to 7d3133d Compare August 22, 2016 14:21
@bobeal
Copy link
Member Author

bobeal commented Aug 22, 2016

That's right, currently, DC Exporter is useless without CKAN.

As CKAN is instantiable via the catalog, I've not added it in the Bootstrap
process.

Maybe we could just add the manual part of the process, its declaration in
the catalog ?

On Mon, Aug 22, 2016 at 3:56 PM, Thomas Broyer [email protected]
wrote:

Should we also bootstrap CKAN btw? (as I understand it, DC Exporter is
rather useless without CKAN, right?)


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#13 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKtFlDnrCYuYSUq_6w3gWG_tSotfdRGks5qiap4gaJpZM4Jh1Pe
.

Benoit Orihuela
Ozwillo Technical Coordinator
Direct Phone : +33 (0)6 87 42 71 07

@tbroyer
Copy link
Contributor

tbroyer commented Aug 22, 2016

Yes. Either that or finally reverting your change to add DC Exporter to the bootstrapping (FWIW, CKAN is the only one with a publicly visible catalog entry)

@bobeal
Copy link
Member Author

bobeal commented Aug 23, 2016

If I revert the change to add DCExporter to the bootstrapping, it will make
the installation process more painful by requiring to add the application,
instance and service directly into Mongo (AFAIK).

Yes, CKAN is the only one to be publicly visible in the catalog ... but it
has to be added in it before :-). Currently, I've documented a manuel
process for this (generating secrets, UUID, ... then inserting it into
Mongo) but it would be better to have it automatised.

We could even go as far as the creation of the instance and service for the
Ozwillo organisation but, as it can be easily done via the portal, it may
not be necessary.

On Mon, Aug 22, 2016 at 6:45 PM, Thomas Broyer [email protected]
wrote:

Yes. Either that or finally reverting your change to add DC Exporter to
the bootstrapping (FWIW, CKAN is the only one with a publicly visible
catalog entry)


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#13 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKtFiTtPM9K8i2xGic-5WW1iG7AyGKpks5qidIRgaJpZM4Jh1Pe
.

Benoit Orihuela
Ozwillo Technical Coordinator
Direct Phone : +33 (0)6 87 42 71 07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants