-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#11 #12 - Bootstrap enhancements #13
base: master
Are you sure you want to change the base?
Conversation
Build seems to fail because of the version update of error prone in 506ba4f ... as I can see in tbroyer/gradle-errorprone-plugin#18 :-) Downgrading it for the build to pass. |
build.gradle
Outdated
@@ -38,7 +38,7 @@ subprojects { | |||
|
|||
apply plugin: 'net.ltgt.errorprone' | |||
configurations.errorprone { | |||
resolutionStrategy.force 'com.google.errorprone:error_prone_core:2.0.11' | |||
resolutionStrategy.force 'com.google.errorprone:error_prone_core:2.0.5' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe I already have a fix for that, I must have forgotten to push it to the public repo on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, that was it: forgot to push 7223c85
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you prefer to handle it wrt this PR ? Rebase the branch on master or merge master into it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll rebase anyway; but please rebase the branch (skipping this commit) to fix conflicts (in INSTALL.md, in other commits). Also, as you're at it, squash the last two commits into the appropriate previous commits to keep the history as clean as possible.
Should we also bootstrap CKAN btw? (as I understand it, DC Exporter is rather useless without CKAN, right?) |
c4a9e4b
to
7d3133d
Compare
That's right, currently, DC Exporter is useless without CKAN. As CKAN is instantiable via the catalog, I've not added it in the Bootstrap Maybe we could just add the manual part of the process, its declaration in On Mon, Aug 22, 2016 at 3:56 PM, Thomas Broyer [email protected]
Benoit Orihuela |
Yes. Either that or finally reverting your change to add DC Exporter to the bootstrapping (FWIW, CKAN is the only one with a publicly visible catalog entry) |
If I revert the change to add DCExporter to the bootstrapping, it will make Yes, CKAN is the only one to be publicly visible in the catalog ... but it We could even go as far as the creation of the instance and service for the On Mon, Aug 22, 2016 at 6:45 PM, Thomas Broyer [email protected]
Benoit Orihuela |
No description provided.