Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Resolve 'frame is null' errors #269

Merged
merged 1 commit into from
Mar 2, 2016

Commits on Mar 2, 2016

  1. Resolve 'frame is null' errors

    As shown in pull request oyvindkinsey#120 and currently shown on twitter.com home timeline when scrolling rapidly, the waitForReady function can complain that the frame is null. The probable cause is that the waitForReady method isn't torn down in the destroy method. So if an iframe is destroyed before it initialises, it can throw this kind of error.
    
    twitter.com:
    `Uncaught TypeError: Cannot read property 'contentWindow' of null`
    
    I've pulled out the function and added an unbind. I think this makes sense.
    (Edited through github editor - needs verification/testing)
    kennethkufluk committed Mar 2, 2016
    Configuration menu
    Copy the full SHA
    1ad4261 View commit details
    Browse the repository at this point in the history