This repository has been archived by the owner on Apr 20, 2023. It is now read-only.
Add support for passing parameters to provider through hash along with existing hash #215
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes easyXDM play nicely with an existing hash in the URL for a provider page.
I needed this to work, because I'm passing other parameters to JavaScript running on a cached page. The caching is affected by the query string, so I want all the parameters, including easyXDM's, to be passed through the hash.
However, currently it tacks on the original hash incorrectly, like this:
/?querystring#easyxdm#original
. This small change makes it behave the same as it does with the query string:/?querystring#original&easyxdm
and detect whether to add a&
or#
after the original URL + original hash.I added some tests, but there was no simple way to change the value of
useHash
, since it's effectively a global variable setup along with a socket. Please let me know if there's some way I should change this to work nicer with the other tests.