Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Add support for passing parameters to provider through hash along with existing hash #215

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

robbles
Copy link

@robbles robbles commented Mar 22, 2013

This makes easyXDM play nicely with an existing hash in the URL for a provider page.

I needed this to work, because I'm passing other parameters to JavaScript running on a cached page. The caching is affected by the query string, so I want all the parameters, including easyXDM's, to be passed through the hash.

However, currently it tacks on the original hash incorrectly, like this: /?querystring#easyxdm#original. This small change makes it behave the same as it does with the query string: /?querystring#original&easyxdm and detect whether to add a & or # after the original URL + original hash.

I added some tests, but there was no simple way to change the value of useHash, since it's effectively a global variable setup along with a socket. Please let me know if there's some way I should change this to work nicer with the other tests.

@oyvindkinsey oyvindkinsey force-pushed the master branch 3 times, most recently from 4e46f32 to 2769b63 Compare April 8, 2019 17:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant