remove example library code (use nupkg instead) #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sample project in this repo includes an example browser, which is based on the example library at https://github.com/oxyplot/oxyplot/tree/develop/Source/Examples/ExampleLibrary. However the example-library code has been copied into this repository, which is not a good idea IMHO (it is outdated already and does not include the latest samples, and this will get worse over time).
Therefore this PR removes the ExampleLibrary code from the repository and uses the corresponding nupkg instead. For this to work I had to revert one commit (efee33c) by @iniceice88, which made some modifications to the ExampleLibrary (exposing
ExampleInfo.Example
and makingExampleInfo.Example.Controller
settable). These modifications could either be upstreamed into https://github.com/oxyplot/oxyplot, or they could alternatively be included as a custom sample that is not part of the example library.@iniceice88 Is this PR ok with you?