Userconfig with DisappearingMessage v2 #2784
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reparation for disappearing messages added panel buttons specific to this UI
… and xl margin option
added expirationType and lastDisappearingMessageChangeTimestamp to conversations table, left a few comments for future work
this is more explicit and allows use to use DisappearingMessageType in the message model
added to migration
…ated message pipeline this includes sync messages and updating the protobuf, haven't tested closed groups
updated copy for setting change messages
updated in parts but haven't test what happens
improved setExpirationStartTimestamp logic
…after they expire
show disappearing message screen when clicking the correct option
fixed opening correct settings option depending on header option displayed
the previous logic relied on the length of the subtitles array which didn't account for when it changed depending on the conversation we were on
…eReadableMessage this stops us passing props down from the child components of ExpirableReadableMessage
…ting an attachment from disk
…o we have to make deleteData more robust javascript ¯\_(ツ)_/¯
…the default fixed session radio button flickering
converted scss toast styling to styled components
since we need an id unaffected by localisation
… a string in react
…userconfig_disappearingmessage
as the circular dependency was causing a createSelector called with undefined issue on startup without user loggedin
Bilb
force-pushed
the
userconfig_disappearingmessage
branch
from
41f19eb
to
b5f85e0
Compare
|
this is part of #2940 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.