-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Profile Picture UI #2765
Improved Profile Picture UI #2765
Conversation
yougotwill
commented
May 23, 2023
•
edited
Loading
edited
- Converted EditProfileDialog to a functional component.
- Added a modal to edit the user's profile picture
- Supports updating and removing the profile picture
- Added proper typings to icons and added thumbnail icon
- Updated profile picture integration tests
- Sort localised keys alphabetically
4705c10
to
a955ad2
Compare
Merge unstable to clearnet with userconfig
Merge userconfig scheduled release
still need to do logic and handle multiple modals on screen
…EditProfileDialog show loading spinner while avatar is loading
…n message disabled buttons while loading
confirmed support for svgs with multiple paths
853011a
to
41d2760
Compare
except for linked device profile sync, need to update avatar-update-blue files for linux
- loop until match when validating screenshot - wait 15s and take screenshot when updating screenshot
test: fix update profile picture snapshots
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a specific reason to change the test name here? If there is I will update the mobile platforms but otherwise we should keep the tests name unchanged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason is so that we can update all profile picture snapshots through one command.
If we do yarn run integration-test-snapshots
it does npx playwright test -g 'profile picture' --update-snapshots"
which will run the "Check profile picture syncs" test and create a new snapshot. The "Change avatar" test had to be run manually. By making it profile picture both tests run off the same command.
So it's more of a convenience thing. Happy to change it back if it is going to cause problems?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So its updating both the linked device test and the change avatar test in one go, if you change the name of the change avatar test? Is it a script that you've created or is this playwright functionality?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's using the "-g" flag it will look for any tests that contain the string 'profile picture' and only those 2 tests match. No additional scripts have been added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, will update the appium tests to match👌
…test has been completed
Closing this inf favor if #2869 |