-
-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ast_tools): derives for ContentEq
and ContentHash
use same ignore list
#8427
Merged
graphite-app
merged 1 commit into
main
from
01-10-refactor_ast_tools_derives_for_contenteq_and_contenthash_use_same_ignore_list
Jan 11, 2025
Merged
refactor(ast_tools): derives for ContentEq
and ContentHash
use same ignore list
#8427
graphite-app
merged 1 commit into
main
from
01-10-refactor_ast_tools_derives_for_contenteq_and_contenthash_use_same_ignore_list
Jan 11, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-ast-tools
Area - AST tools
C-cleanup
Category - technical debt or refactoring. Solution not expected to change behavior
labels
Jan 10, 2025
overlookmotel
force-pushed
the
01-10-fix_ast_fix_contenteq_and_contenthash_impls_for_literal_types
branch
2 times, most recently
from
January 10, 2025 22:45
afd202f
to
21aa03e
Compare
overlookmotel
force-pushed
the
01-10-refactor_ast_tools_derives_for_contenteq_and_contenthash_use_same_ignore_list
branch
from
January 10, 2025 22:45
c7e3800
to
11cb904
Compare
Boshen
changed the base branch from
01-10-fix_ast_fix_contenteq_and_contenthash_impls_for_literal_types
to
graphite-base/8427
January 11, 2025 02:42
Boshen
force-pushed
the
graphite-base/8427
branch
from
January 11, 2025 02:46
21aa03e
to
97a7992
Compare
Boshen
force-pushed
the
01-10-refactor_ast_tools_derives_for_contenteq_and_contenthash_use_same_ignore_list
branch
from
January 11, 2025 02:46
11cb904
to
1916952
Compare
Boshen
force-pushed
the
01-10-refactor_ast_tools_derives_for_contenteq_and_contenthash_use_same_ignore_list
branch
from
January 11, 2025 02:47
1916952
to
f310ed9
Compare
Merge activity
|
…me ignore list (#8427) Pure refactor. Share the same field ignore list between the codegens for deriving `ContentEq` and `ContentHash` to prevent them getting out of sync.
Boshen
force-pushed
the
01-10-refactor_ast_tools_derives_for_contenteq_and_contenthash_use_same_ignore_list
branch
from
January 11, 2025 07:18
f310ed9
to
91b0134
Compare
graphite-app
bot
deleted the
01-10-refactor_ast_tools_derives_for_contenteq_and_contenthash_use_same_ignore_list
branch
January 11, 2025 07:22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
0-merge
Merge with Graphite Merge Queue
A-ast-tools
Area - AST tools
C-cleanup
Category - technical debt or refactoring. Solution not expected to change behavior
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pure refactor. Share the same field ignore list between the codegens for deriving
ContentEq
andContentHash
to prevent them getting out of sync.