Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ast_tools): derives for ContentEq and ContentHash use same ignore list #8427

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Jan 10, 2025

Pure refactor. Share the same field ignore list between the codegens for deriving ContentEq and ContentHash to prevent them getting out of sync.

Copy link
Contributor Author

overlookmotel commented Jan 10, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jan 10, 2025
@overlookmotel overlookmotel marked this pull request as ready for review January 10, 2025 21:58
@overlookmotel overlookmotel force-pushed the 01-10-fix_ast_fix_contenteq_and_contenthash_impls_for_literal_types branch 2 times, most recently from afd202f to 21aa03e Compare January 10, 2025 22:45
@overlookmotel overlookmotel force-pushed the 01-10-refactor_ast_tools_derives_for_contenteq_and_contenthash_use_same_ignore_list branch from c7e3800 to 11cb904 Compare January 10, 2025 22:45
@Boshen Boshen changed the base branch from 01-10-fix_ast_fix_contenteq_and_contenthash_impls_for_literal_types to graphite-base/8427 January 11, 2025 02:42
@Boshen Boshen force-pushed the graphite-base/8427 branch from 21aa03e to 97a7992 Compare January 11, 2025 02:46
@Boshen Boshen force-pushed the 01-10-refactor_ast_tools_derives_for_contenteq_and_contenthash_use_same_ignore_list branch from 11cb904 to 1916952 Compare January 11, 2025 02:46
@Boshen Boshen changed the base branch from graphite-base/8427 to main January 11, 2025 02:47
@Boshen Boshen force-pushed the 01-10-refactor_ast_tools_derives_for_contenteq_and_contenthash_use_same_ignore_list branch from 1916952 to f310ed9 Compare January 11, 2025 02:47
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jan 11, 2025
Copy link
Member

Boshen commented Jan 11, 2025

Merge activity

  • Jan 11, 2:17 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 11, 2:17 AM EST: A user added this pull request to the Graphite merge queue.
  • Jan 11, 2:22 AM EST: A user merged this pull request with the Graphite merge queue.

…me ignore list (#8427)

Pure refactor. Share the same field ignore list between the codegens for deriving `ContentEq` and `ContentHash` to prevent them getting out of sync.
@Boshen Boshen force-pushed the 01-10-refactor_ast_tools_derives_for_contenteq_and_contenthash_use_same_ignore_list branch from f310ed9 to 91b0134 Compare January 11, 2025 07:18
@graphite-app graphite-app bot merged commit 91b0134 into main Jan 11, 2025
15 checks passed
@graphite-app graphite-app bot deleted the 01-10-refactor_ast_tools_derives_for_contenteq_and_contenthash_use_same_ignore_list branch January 11, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants