protocol.md: Fix note formatting and add a note about annotations and image lists #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(The Pulp folks asked for that clarification in response to my work-in-progress implementation of this protocol for Pulp at <pulp/pulp_container#1301> "Implement flatpak index view".)
lubosmj
reviewed
Jun 22, 2023
| @@ -109,4 +115,6 @@ The basic structure of the JSON returned from a request is: | |||
|
|
|||
| Notes | |||
| ----- | |||
| * For images within an image list, the architecture matched by `architecture=` queries and returned in the JSON result is the architecture extracted from the images `config.json`, not the architecture in the manifest list or image index. | |||
| * For images within an image list, the architecture matched by `architecture=` queries and returned in the JSON result is the architecture extracted from the images `config.json`, not the architecture in the manifest list or image index. | |||
There was a problem hiding this comment.
Suggested change
| * For images within an image list, the architecture matched by `architecture=` queries and returned in the JSON result is the architecture extracted from the images `config.json`, not the architecture in the manifest list or image index. | |
| * For images within a manifest list or OCI index, the architecture matched by `architecture=` queries and returned in the JSON result is the architecture extracted from the images `config.json`. |
The architecture attribute must be specified in respective listed manifests: https://docs.docker.com/engine/reference/commandline/manifest/#inspect-a-manifest-list, https://github.com/opencontainers/image-spec/blob/main/image-index.md#image-index-property-descriptions. What is the rationale behind this statement, @owtaylor?
There was a problem hiding this comment.
Oh, my bad, the platform object that holds the architecture attribute is optional.
stbergmann
force-pushed
the
protocolnotes
branch
2 times, most recently
from
730d0c1
to
29040c2
Compare
...as was discussed elsewhere now
stbergmann
force-pushed
the
protocolnotes
branch
from
29040c2
to
588a35d
Compare
owtaylor
added a commit
to owtaylor/flatpak-oci-specs
that referenced
this pull request
Jun 30, 2023
Specify that if a parameter is repeated (arch=amd64&arch=arm64), this is treated as OR. This matches the original Flagstate implementation, and is more useful than AND, since the result of such a query would always be empty. Based on changes from Stephan Bergmann <[email protected]>; see owtaylor/flagstate#6
|
Abandoned in favor of flatpak/flatpak-oci-specs#1 "Add an appending describing how Flatpak uses the specification" and flatpak/flatpak-oci-specs#2 "Registry Index: multiple parameters with the same key are OR'ed together". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.