Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]add test for creating and listing auth token for an app using api #10662

Merged
merged 2 commits into from
Dec 11, 2024
Merged

[tests-only][full-ci]add test for creating and listing auth token for an app using api #10662

merged 2 commits into from
Dec 11, 2024

Conversation

nirajacharya2
Copy link
Contributor

@nirajacharya2 nirajacharya2 commented Nov 26, 2024 •
edited
Loading

Description

This PR tests creating and listing token feature of auth-app service.
https://owncloud.dev/services/auth-app/#app-tokens

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nirajacharya2 nirajacharya2 self-assigned this Nov 26, 2024
@nirajacharya2 nirajacharya2 mentioned this pull request Nov 26, 2024
Open
22 tasks
@nirajacharya2 nirajacharya2 force-pushed the test-auth-app-token-api branch from 0aca4b3 to 95f3c22 Compare November 27, 2024 09:54
@nirajacharya2
Copy link
Contributor Author

nirajacharya2 commented Nov 27, 2024 •
edited
Loading

need to confirm how to delete the token.
#10675

im pausing this pr for now.

@nirajacharya2 nirajacharya2 changed the title [tests-only][full-ci]add test for creating auth tocken for an app using api [tests-only][full-ci]add test for creating auth token for an app using api Nov 28, 2024
@nirajacharya2 nirajacharya2 force-pushed the test-auth-app-token-api branch from 95f3c22 to 214ba46 Compare November 29, 2024 08:36
@nirajacharya2
Copy link
Contributor Author

need to confirm how to delete the token. #10675

im pausing this pr for now.

skipping delete test.

@nirajacharya2 nirajacharya2 force-pushed the test-auth-app-token-api branch 9 times, most recently from 46eab2e to 1fffc93 Compare December 2, 2024 08:19
@nirajacharya2 nirajacharya2 changed the title [tests-only][full-ci]add test for creating auth token for an app using api [tests-only][full-ci]add test for creating and listing auth token for an app using api Dec 2, 2024
@nirajacharya2 nirajacharya2 marked this pull request as ready for review December 2, 2024 09:04
@nirajacharya2 nirajacharya2 force-pushed the test-auth-app-token-api branch from 4ea39d5 to 80b9b73 Compare December 9, 2024 10:19
@nirajacharya2 nirajacharya2 requested a review from saw-jan December 9, 2024 10:53
@nirajacharya2 nirajacharya2 force-pushed the test-auth-app-token-api branch 2 times, most recently from af504dc to 6c2e366 Compare December 10, 2024 03:28
@nirajacharya2 nirajacharya2 force-pushed the test-auth-app-token-api branch 2 times, most recently from bf3455d to 35059a0 Compare December 10, 2024 06:29
@nirajacharya2 nirajacharya2 force-pushed the test-auth-app-token-api branch from 35059a0 to a36ed90 Compare December 10, 2024 08:37
saw-jan
saw-jan reviewed Dec 10, 2024
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use service name

tests/acceptance/features/apiAuthApp/token.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiAuthApp/token.feature Outdated Show resolved Hide resolved
@nirajacharya2 nirajacharya2 force-pushed the test-auth-app-token-api branch from a36ed90 to 3f71502 Compare December 10, 2024 09:07
@nirajacharya2 nirajacharya2 force-pushed the test-auth-app-token-api branch from 3f71502 to 1313124 Compare December 11, 2024 03:26
@nirajacharya2 nirajacharya2 force-pushed the test-auth-app-token-api branch from 1313124 to 7546e47 Compare December 11, 2024 06:10
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@S-Panta S-Panta merged commit 1d2a868 into master Dec 11, 2024
4 checks passed
@S-Panta S-Panta deleted the test-auth-app-token-api branch December 11, 2024 06:47
ownclouders pushed a commit that referenced this pull request Dec 11, 2024
@S-Panta
Merge pull request #10662 from owncloud/test-auth-app-token-api
2b4b09f 
[tests-only][full-ci]add test for creating and listing auth token for an app using api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@anon-pradip anon-pradip Awaiting requested review from anon-pradip

@ScharfViktor ScharfViktor Awaiting requested review from ScharfViktor

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@prashant-gurung899 prashant-gurung899 Awaiting requested review from prashant-gurung899

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@S-Panta S-Panta Awaiting requested review from S-Panta

Assignees

@nirajacharya2 nirajacharya2

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nirajacharya2 @saw-jan @prashant-gurung899 @amrita-shrestha @S-Panta @PrajwolAmatya