Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tip for adding notification service #1122

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mjforan
Copy link

@mjforan mjforan commented Jan 13, 2025

Follow on to #925 - add a note about using OCIS_ADD_RUN_SERVICES to enable the notification service.

@phil-davis phil-davis requested a review from mmattel January 14, 2025 04:05
@mmattel
Copy link
Contributor

mmattel commented Jan 14, 2025

Thanks for your contribution 👍
When looking into the current document, there is on top the statement:
image
The same situation is with the collaboration service which also needs a manual start, see the note there.
I am wondering if we need the text from this PR additionally.

@mjforan
Copy link
Author

mjforan commented Jan 14, 2025

Thanks, I added the note there as well.

@mmattel
Copy link
Contributor

mmattel commented Jan 14, 2025

Hmmm,
you possibly misunderstood ...
As the info is already there, on top and prominent placed as note, I dont think this gives additional value. Just repeating what is already there does not make it better. Moreover, the collaboration service is not easy to configure due to the fact that you need for each web office application an own instance (see compose examples).

Despite the above, I see your point and therefore I am thinking about how to improve.

@mjforan
Copy link
Author

mjforan commented Jan 14, 2025

Right, I wasn't sure which way you meant..

The reason I made this suggestion is that I just configured the notification service myself for the first time. When I read this "Note" I had the question, "after notifications are working, how do I add the service to startup?". To get the answer I had to read the section on "Start Infinite Scale" a few times because I missed the link to the "Special Environmental Variables" page. I am probably not the only user with this question, and it would be convenient to have the answer right there in the "Note".

I understand it may be less useful on the collaboration service. Feel free to remove that one, or close the PR if you don't like the idea at all. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants