-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TECHNICAL] Unit tests for repository classes - Part 1 #4281
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several changes requested here @Aitorbp, you should pay more attention to previous reviews 😅
Also, in this case calens is not working because the name of the branch is incorrect. Pay attention to these details, they can break our normal workflow
...rc/test/java/com/owncloud/android/data/appregistry/repository/OCAppRegistryRepositoryTest.kt
Outdated
Show resolved
Hide resolved
...rc/test/java/com/owncloud/android/data/appregistry/repository/OCAppRegistryRepositoryTest.kt
Outdated
Show resolved
Hide resolved
...rc/test/java/com/owncloud/android/data/appregistry/repository/OCAppRegistryRepositoryTest.kt
Outdated
Show resolved
Hide resolved
...rc/test/java/com/owncloud/android/data/appregistry/repository/OCAppRegistryRepositoryTest.kt
Outdated
Show resolved
Hide resolved
...rc/test/java/com/owncloud/android/data/appregistry/repository/OCAppRegistryRepositoryTest.kt
Outdated
Show resolved
Hide resolved
...rc/test/java/com/owncloud/android/data/capabilities/repository/OCCapabilityRepositoryTest.kt
Outdated
Show resolved
Hide resolved
...rc/test/java/com/owncloud/android/data/capabilities/repository/OCCapabilityRepositoryTest.kt
Show resolved
Hide resolved
owncloudTestUtil/src/main/java/com/owncloud/android/testutil/OCCapability.kt
Outdated
Show resolved
Hide resolved
owncloudTestUtil/src/main/java/com/owncloud/android/testutil/OCCapability.kt
Outdated
Show resolved
Hide resolved
owncloudTestUtil/src/main/java/com/owncloud/android/testutil/OCCapability.kt
Show resolved
Hide resolved
92ef3c5
to
7b97e04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second round of CR here @Aitorbp
owncloudTestUtil/src/main/java/com/owncloud/android/testutil/OCCapability.kt
Outdated
Show resolved
Hide resolved
...rc/test/java/com/owncloud/android/data/appregistry/repository/OCAppRegistryRepositoryTest.kt
Outdated
Show resolved
Hide resolved
...rc/test/java/com/owncloud/android/data/appregistry/repository/OCAppRegistryRepositoryTest.kt
Outdated
Show resolved
Hide resolved
...rc/test/java/com/owncloud/android/data/appregistry/repository/OCAppRegistryRepositoryTest.kt
Outdated
Show resolved
Hide resolved
...rc/test/java/com/owncloud/android/data/appregistry/repository/OCAppRegistryRepositoryTest.kt
Outdated
Show resolved
Hide resolved
...rc/test/java/com/owncloud/android/data/appregistry/repository/OCAppRegistryRepositoryTest.kt
Outdated
Show resolved
Hide resolved
...t/java/com/owncloud/android/data/authentication/repository/OCAuthenticationRepositoryTest.kt
Outdated
Show resolved
Hide resolved
...rc/test/java/com/owncloud/android/data/appregistry/repository/OCAppRegistryRepositoryTest.kt
Show resolved
Hide resolved
...rc/test/java/com/owncloud/android/data/capabilities/repository/OCCapabilityRepositoryTest.kt
Outdated
Show resolved
Hide resolved
...rc/test/java/com/owncloud/android/data/capabilities/repository/OCCapabilityRepositoryTest.kt
Outdated
Show resolved
Hide resolved
742a5d4
to
ad521d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more change here @Aitorbp
...rc/test/java/com/owncloud/android/data/capabilities/repository/OCCapabilityRepositoryTest.kt
Outdated
Show resolved
Hide resolved
2c942c4
to
3f1b3ba
Compare
…sts and improvements
…perty in OC_CAPABILITY_WITH_FILES_APP_PROVIDERS
3f1b3ba
to
788c051
Compare
788c051
to
4d58911
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now!
Related Issues
App: #4232