chore(fuzzywuzzy): use thefuzz, fix levenshtein #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasrodes
changed the title
Marigold
reviewed
Jan 9, 2023
| @@ -40,7 +40,7 @@ Unidecode = ">=1.3.2" | |||
| python-dotenv = ">=0.19.0" | |||
| frictionless = {extras = ["pandas"], version = ">=4.40.8"} | |||
| thefuzz = ">=0.19.0" | |||
| python-Levenshtein = ">=0.12.2" | |||
| python-Levenshtein = "^0.12.2" | |||
There was a problem hiding this comment.
Could be useful to add a note explaining why is it pinned and link the issue. This will make it easier to unpin in the future.
Marigold
approved these changes
Jan 9, 2023
|
Thanks, @Marigold! Added a short comment referencing the issue with |
This was referenced Jan 9, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fuzzywuzzy:thefuzz. See https://github.com/seatgeek/fuzzywuzzy for more details.thefuzzin some instances.python-Levensteinto a specific version. Otherwise,thefuzzusage will fail, because of a known bug: See NameError: name 'matching_blocks' is not defined seatgeek/thefuzz#43, PyPI package name conflict rapidfuzz/python-Levenshtein#1, replace python-Levenshtein with rapidfuzz seatgeek/thefuzz#10,I noticed this error when trying to run
walkthrough charts. It would not work, because it relies onthefuzz.