Enable and fix linting

ovotech · Jul 21, 2023 · ff124e5 · ff124e5
1 parent 09f669e
commit ff124e5
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 18 deletions.
diff --git a/.github/workflows/on-push.yml b/.github/workflows/on-push.yml
@@ -3,18 +3,18 @@ name: On Push
 on: [push]
 
 jobs:
-#  lint:
-#    runs-on: ubuntu-latest
-#    steps:
-#      - uses: actions/checkout@v3
-#      - name: Setup Node
-#        uses: actions/setup-node@v1
-#        with:
-#          node-version: 16.x
-#      - run: yarn
-#      - run: yarn lint
-#        env:
-#          CI: true
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - name: Setup Node
+        uses: actions/setup-node@v3
+        with:
+          node-version: 16.x
+      - run: yarn
+      - run: yarn lint
+        env:
+          CI: true
 
   test-and-build:
     runs-on: ubuntu-latest

diff --git a/examples/api/src/ts-script.ts b/examples/api/src/ts-script.ts
@@ -8,10 +8,14 @@ import {
 require('dotenv').config({ path: '../../.env' });
 
 (async () => {
+  if (!process.env.DEPLOYMENT_ID || !process.env.REGION) {
+    throw new Error('Environment vars DEPLOYMENT_ID and REGION missing. They must be defined');
+  }
+
   // << test-section
   const session = new WebMessengerGuestSession({
-    deploymentId: process.env.DEPLOYMENT_ID!,
-    region: process.env.REGION!,
+    deploymentId: process.env.DEPLOYMENT_ID,
+    region: process.env.REGION,
   });
 
   new Transcriber(session).on('messageTranscribed', (i) => console.log(i.toString()));

diff --git a/examples/api/tsconfig.json b/examples/api/tsconfig.json
@@ -0,0 +1,3 @@
+{
+  "extends": "../../tsconfig.json"
+}
diff --git a/packages/genesys-web-messaging-tester-cli/src/fileSystem/yamlFileReader.ts b/packages/genesys-web-messaging-tester-cli/src/fileSystem/yamlFileReader.ts
@@ -9,16 +9,14 @@ export function createYamlFileReader(fsReadFileSync: typeof readFileSync): YamlF
     try {
       content = fsReadFileSync(path, 'utf8');
     } catch (error) {
-      // @ts-ignore
-      throw new Error(`Failed to read file '${path}'. Reason: ${error.message}`);
+      throw new Error(`Failed to read file '${path}'. Reason: ${String(error)}`);
     }
 
     let yamlContent: unknown;
     try {
       yamlContent = yaml.load(content);
     } catch (error) {
-      // @ts-ignore
-      throw new Error(`File '${path}' not valid YAML. Reason: ${error.message}`);
+      throw new Error(`File '${path}' not valid YAML. Reason: ${String(error)}`);
     }
 
     if (