Show diff when approved and current plans differ, remove state lock message from plan #567
+21
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarlingovo
requested review from
enicholson125,
mattslane,
ovo-dsingh,
kizzie,
enza252 and
NathanMarshOVO
tarlingovo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://ovotech.atlassian.net/browse/BSNSS-2630
For "Plan has changed" errors, show a diff between the approved and current plan in the CI logs
Also, remove "Releasing state lock." message when comparing plans since this can appear in either plan, but can be discounted in the comparison.