Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pci-object-storage): round price to integer #15299

Merged
merged 1 commit into from
Feb 4, 2025
Merged

fix(pci-object-storage): round price to integer #15299

merged 1 commit into from
Feb 4, 2025
+9 −1

Conversation

SimonChaumet
Copy link
Contributor

@SimonChaumet SimonChaumet commented Feb 4, 2025 •
edited
Loading

ref: TAPC-2792

Question Answer
Branch? master
Bug fix? yes
New feature? yes
Breaking change? no
Tickets Fix #TAPC-2792
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@SimonChaumet
fix(pci-object-storage): round price to integer
ce6eff0 
ref: TAPC-2792

Signed-off-by: Simon Chaumet <[email protected]>
@SimonChaumet SimonChaumet requested a review from a team as a code owner February 4, 2025 14:19
@github-actions github-actions bot added universe-public-cloud bug Something isn't working labels Feb 4, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 4, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@SimonChaumet SimonChaumet changed the base branch from master to release/incidents-pci-w6 February 4, 2025 17:39
@SimonChaumet SimonChaumet merged commit d6ecde4 into release/incidents-pci-w6 Feb 4, 2025
25 checks passed
@SimonChaumet SimonChaumet deleted the fix/TAPC-2792 branch February 4, 2025 17:47
@SimonChaumet SimonChaumet mentioned this pull request Feb 4, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tibs245 tibs245 tibs245 approved these changes

@JacquesLarique JacquesLarique JacquesLarique approved these changes

@Tsiorifamonjena Tsiorifamonjena Tsiorifamonjena approved these changes

@tristanwagner tristanwagner tristanwagner approved these changes

@aottr aottr Awaiting requested review from aottr aottr is a code owner automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
bug Something isn't working quality check: ok universe-public-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SimonChaumet @tibs245 @tristanwagner @Tsiorifamonjena @JacquesLarique