remove unnecessary fullscreen pass when haze is off/disabled #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HifiExperiments
added
enhancement
ksuprynowicz
approved these changes
Nov 1, 2024
ksuprynowicz
added
CR approved
|
I'm having trouble testing since it's on older protocol version. Can we rebase it on current master? |
|
done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in deferred rendering mode, haze is applied as a fullscreen pass after we've rendered opaque objects. but when haze is off, this shader still runs and just early exits. this is expensive for no reason, we can just early exit on the CPU