Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: explain release vs main for Tutor contributors #1173

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

kdmccormick
Copy link
Collaborator

This information is touched on at the end of the Tutor Main tutorial, but I think it would be good to add some conceptual explanation here in the Contribution guide as well.

@kdmccormick
Copy link
Collaborator Author

@regisb or @DawoudSheraz , could you take a look?

I'm also going to solicit input from someone who isn't a Tutor maintainer so that we know that this all makes sense to somebody on the outside.

docs/tutor.rst Outdated Show resolved Hide resolved
Co-authored-by: Sarina Canelake <[email protected]>
@kdmccormick
Copy link
Collaborator Author

kdmccormick commented Dec 4, 2024

Thanks Sarina.

Also, from Slack, regarding this new section:

Brian Mesick
Made sense to me!

Copy link

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

docs/tutor.rst Outdated Show resolved Hide resolved
docs/tutor.rst Outdated Show resolved Hide resolved
@kdmccormick
Copy link
Collaborator Author

Reviewers, let me know if you have any issues with the new sentence I'm adding based on Dawoud's corrections.

@sarina
Copy link
Contributor

sarina commented Dec 4, 2024

LGTM 👍🏻

@kdmccormick kdmccormick merged commit dafc30d into release Dec 4, 2024
2 checks passed
@kdmccormick kdmccormick deleted the kdmccormick/branch-docs branch December 4, 2024 16:47
Copy link
Contributor

@regisb regisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm late to the game, but this is a great change. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

5 participants